From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: What happened to the key-menu patch? Date: 09 Jul 2002 16:00:13 +0900 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200205050534.g455YfF01634@aztec.santafe.edu> <5xbsbumexh.fsf@kfs2.cua.dk> <200205141941.g4EJfud15293@aztec.santafe.edu> <5xvg9qmgzt.fsf@kfs2.cua.dk> <200205151927.g4FJRRW26103@rum.cs.yale.edu> <5x3cwr4q7m.fsf@kfs2.cua.dk> <87g00rd74y.fsf@tc-1-100.kawasaki.gol.ne.jp> <87sn4otknt.fsf@tc-1-100.kawasaki.gol.ne.jp> <200205191441.g4JEfMg23080@rum.cs.yale.edu> <200205202134.g4KLYHj26031@aztec.santafe.edu> <200205222227.g4MMRIX29393@aztec.santafe.edu> <87g0030xah.fsf@tc-1-100.kawasaki.gol.ne.jp> <5xn0t3p362.fsf_-_@kfs2.cua.dk> Reply-To: Miles Bader NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1026198054 2017 127.0.0.1 (9 Jul 2002 07:00:54 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2002 07:00:54 +0000 (UTC) Cc: rms@gnu.org, monnier+gnu/emacs@RUM.cs.yale.edu, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17RozW-0000WQ-00 for ; Tue, 09 Jul 2002 09:00:54 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17Rp7p-0003qD-00 for ; Tue, 09 Jul 2002 09:09:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17Rozk-0004pb-00; Tue, 09 Jul 2002 03:01:08 -0400 Original-Received: from tyo201.gate.nec.co.jp ([202.32.8.214]) by fencepost.gnu.org with smtp (Exim 3.35 #1 (Debian)) id 17RozP-0004p0-00; Tue, 09 Jul 2002 03:00:48 -0400 Original-Received: from mailgate4.nec.co.jp ([10.7.69.197]) by TYO201.gate.nec.co.jp (8.11.6/3.7W01080315) with ESMTP id g6970MR19425; Tue, 9 Jul 2002 16:00:22 +0900 (JST) Original-Received: from mailsv.nec.co.jp (mailgate51.nec.co.jp [10.7.69.196]) by mailgate4.nec.co.jp (8.11.6/3.7W-MAILGATE-NEC) with ESMTP id g6970Mo20906; Tue, 9 Jul 2002 16:00:22 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp ([10.30.114.133]) by mailsv.nec.co.jp (8.11.6/3.7W-MAILSV-NEC) with ESMTP id g6970J412839; Tue, 9 Jul 2002 16:00:19 +0900 (JST) Original-Received: from mcspd15.ucom.lsi.nec.co.jp (mcspd15 [10.30.114.174]) by mcsss2.ucom.lsi.nec.co.jp (8.10.2+Sun/3.7Wlsi_mx_6.0) with ESMTP id g6970IK21697; Tue, 9 Jul 2002 16:00:18 +0900 (JST) Original-Received: by mcspd15.ucom.lsi.nec.co.jp (Postfix, from userid 31295) id 1FEB537D5; Tue, 9 Jul 2002 16:00:13 +0900 (JST) Original-To: storm@cua.dk (Kim F. Storm) System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: <5xn0t3p362.fsf_-_@kfs2.cua.dk> Original-Lines: 57 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5592 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5592 storm@cua.dk (Kim F. Storm) writes: > What happened to this patch? > > There was some discussion how to accomplish this in a more general way > such as adding dobinding/map-keymap to be able to do more of the > function in Lisp, rather than in C (modifying the C-level code to use > Fmap_keymap as well). I intend to do this (move the keymap interpretation into lisp), but haven't got around to it yet. I guess we should add a `map-keymap' for xemacs compatibility; I'm not sure if it's worth it to add a `dobindings' macro or not. Also, the xemacs docstring for `map-keymap' says: `map-keymap' is a built-in function (map-keymap FUNCTION KEYMAP &optional SORT-FIRST) Apply FUNCTION to each element of KEYMAP. FUNCTION will be called with two arguments: a key-description list, and the binding. ...etc... There are a few things I'm not sure about: (1) The xemacs manual doesn't seem to explain very well what `a key-description list' is, but it's something like (meta control x). I guess this is a canonical format for key names in xemacs, but it doesn't appear to be so in emacs, so I'm not sure how that argument should be handled (perhaps just punt, and pass whatever's stored in the keymap). (2) How are menu entries handled with this? I'm not sure whether xemacs even stores menus in keymaps or not (it's somewhat hard to tell, since keyaps are an opaque type in xemacs, and just calling map-keymap doesn't yield anything obvious). We could just pass the whole menu entry (e.g., (menu-item ...)) as the first argument, and perhaps extract the binding and pass it as the second arg, or even pass something else for that. > Also, there was some discussion on improving the actual prompting, > but none of the alleged problems made have been bothering me [after all, > those key menus are not used very often]. Which problems? I have a newer patch (at least I hope I still have it; I'm at work now) that fixed some of the issues like menus bigger than the maximum minibuffer size, but they're probably not things that would affect the usual case (unless you're Stephan). The other issue was that of a delay for menu popup, which you didn't like, but I feel strongly should be supported, since I don't like the current `eager' display (though the delay could be 0 by default if that's better for newbies). -Miles -- "Most attacks seem to take place at night, during a rainstorm, uphill, where four map sheets join." -- Anon. British Officer in WW I