From: Miles Bader <miles@lsi.nec.co.jp>
Cc: Stefan Monnier <monnier+gnu/emacs@rum.cs.yale.edu>
Subject: Re: gdba probs
Date: 12 Dec 2002 10:24:39 +0900 [thread overview]
Message-ID: <buoel8o81wo.fsf@mcspd15.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <15863.48069.658013.465668@nick.uklinux.net>
Nick Roberts <nick@nick.uklinux.net> writes:
> (defun gud-filter (proc string)
> ;; Here's where the actual buffer insertion is done
> + (when (and gud-first-time (string-match
> + "\n\032\032[a-z]" string))
.....
> + (setq gud-first-time nil))
> (let (output process-window)
Please put all the junk inside the `when' (which I replaced by .....)
into a separate function to avoid cluttering up gud-filter, something
like `gdba-take-over-process' or something. It could even be an
autoloaded function in gdb-ui.el.
The segment of code marked `(re-)initialize' should probably also be put
into a separate function (in gud.el), since set of commands needed may
change in the future, and this keeps things a bit organized. If gud
also calls this function, then it's even more clear.
[Yeah I know gud.el is a big ball of hair already, but there's no sense
in making it worse]
Thanks,
-Miles
--
Love is a snowmobile racing across the tundra. Suddenly it flips over,
pinning you underneath. At night the ice weasels come. --Nietzsche
next prev parent reply other threads:[~2002-12-12 1:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-05 20:40 gdba probs Nick Roberts
2002-12-05 21:49 ` Stefan Monnier
2002-12-07 2:38 ` Nick Roberts
2002-12-07 3:10 ` Miles Bader
2002-12-09 15:46 ` Stefan Monnier
2002-12-10 14:19 ` Stefan Monnier
[not found] ` <15862.30022.647969.267154@nick.uklinux.net>
[not found] ` <200212111411.gBBEBUn03805@rum.cs.yale.edu>
2002-12-11 22:27 ` Nick Roberts
2002-12-11 22:48 ` Stefan Monnier
2002-12-12 0:05 ` Nick Roberts
2002-12-12 13:49 ` Stefan Monnier
2002-12-12 14:13 ` Miles Bader
2002-12-13 22:21 ` Richard Stallman
2002-12-12 1:24 ` Miles Bader [this message]
2002-12-12 10:22 ` Kim F. Storm
2002-12-15 0:36 ` Nick Roberts
2002-12-07 21:25 ` Richard Stallman
2002-12-08 1:55 ` Nick Roberts
2002-12-09 20:21 ` Richard Stallman
2002-12-10 21:39 ` Nick Roberts
2002-12-10 23:44 ` Kim F. Storm
2002-12-11 20:40 ` Richard Stallman
2002-12-08 2:27 ` Miles Bader
2002-12-10 14:14 ` Stefan Monnier
2002-12-11 17:45 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2002-12-05 6:19 Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buoel8o81wo.fsf@mcspd15.ucom.lsi.nec.co.jp \
--to=miles@lsi.nec.co.jp \
--cc=miles@gnu.org \
--cc=monnier+gnu/emacs@rum.cs.yale.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).