From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: emacs.c broken by revision 1.435 Date: Wed, 23 Jul 2008 16:37:55 +0900 Message-ID: References: Reply-To: Miles Bader NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216798706 3339 80.91.229.12 (23 Jul 2008 07:38:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2008 07:38:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Tim Van Holder" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 23 09:39:12 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KLYwJ-0005CH-RU for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2008 09:39:12 +0200 Original-Received: from localhost ([127.0.0.1]:42755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLYvP-00084C-V3 for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2008 03:38:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLYvK-00083q-Qa for emacs-devel@gnu.org; Wed, 23 Jul 2008 03:38:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLYvI-00080q-5S for emacs-devel@gnu.org; Wed, 23 Jul 2008 03:38:09 -0400 Original-Received: from [199.232.76.173] (port=49145 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLYvI-00080k-2g for emacs-devel@gnu.org; Wed, 23 Jul 2008 03:38:08 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:8166) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KLYvF-0004hm-FH; Wed, 23 Jul 2008 03:38:05 -0400 Original-Received: from tyo201.gate.nec.co.jp ([202.32.8.193]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KLYvD-0002WJ-Sj; Wed, 23 Jul 2008 03:38:04 -0400 Original-Received: from relay21.aps.necel.com ([10.29.19.50]) by tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id m6N7blx9004477; Wed, 23 Jul 2008 16:37:56 +0900 (JST) Original-Received: from relay11.aps.necel.com ([10.29.19.16] [10.29.19.16]) by relay21.aps.necel.com with ESMTP; Wed, 23 Jul 2008 16:37:56 +0900 Original-Received: from dhapc248.dev.necel.com ([10.114.112.215] [10.114.112.215]) by relay11.aps.necel.com with ESMTP; Wed, 23 Jul 2008 16:37:56 +0900 Original-Received: by dhapc248.dev.necel.com (Postfix, from userid 31295) id 50C6B5B5; Wed, 23 Jul 2008 16:37:56 +0900 (JST) System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: (Tim Van Holder's message of "Wed, 23 Jul 2008 09:24:54 +0200") Original-Lines: 20 X-detected-kernel: by mx20.gnu.org: Solaris 8 (1) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101287 Archived-At: "Tim Van Holder" writes: > The "LINUX_SBRK_BUG" condition was incorrectly replaced with > > #if (GNU_LINUX) && __GNU_LIBRARY__ - 0 < 6 > > instead of > > #if defined (GNU_LINUX) && __GNU_LIBRARY__ - 0 < 6 > > resulting in a broken build. Why does the first result in a broken build? Seems to work fine with the C compilers I tried it with... (both with GNU_LINUX defined, and with GNU_LINUX undefined) -Miles -- `Suppose Korea goes to the World Cup final against Japan and wins,' Moon said. `All the past could be forgiven.' [NYT]