unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
Subject: question about narrowed behavior of next-property-change et al.
Date: 23 Jan 2003 17:50:15 +0900	[thread overview]
Message-ID: <buo65sgp7w8.fsf@mcspd15.ucom.lsi.nec.co.jp> (raw)

Info contains the following check to avoid refontifying fontified nodes:

   (defun Info-fontify-node ()
     ;; Only fontify the node if it hasn't already been done.
     (unless (next-property-change (point-min))
        ...

However, this often doesn't always work properly because it assumes that
`next-property-change' will return nil if there's no property change
before the narrowed end of the buffer, and in fact if there's a
property change _beyond_ the narrowed end, it will return (point-max),
even though the user passed a LIMIT arg of nil.

It's easy enough to change Info-fontify-node to be more paranoid, but to
me, the current behavior of `next-property-change' seems wrong in this
case -- I think if there's no property change before (point-max), and
the user passed LIMIT == nil, then it should return nil, regardless of
whether (point-max) is due to narrowing or not.

Any comments before I make such a change?

-Miles
-- 
`...the Soviet Union was sliding in to an economic collapse so comprehensive
 that in the end its factories produced not goods but bads: finished products
 less valuable than the raw materials they were made from.'  [The Economist]

             reply	other threads:[~2003-01-23  8:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23  8:50 Miles Bader [this message]
2003-01-23 16:12 ` question about narrowed behavior of next-property-change et al Stefan Monnier
2003-01-24  5:43 ` Richard Stallman
2003-01-24  6:06   ` Miles Bader
2003-01-25 19:23     ` Richard Stallman
2003-01-26  1:12       ` Stefan Monnier
2003-01-27  2:31         ` Richard Stallman
2003-01-27 13:33           ` Stefan Monnier
2003-01-27 14:52             ` Miles Bader
2003-01-29  0:06               ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buo65sgp7w8.fsf@mcspd15.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).