unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles.bader@necel.com>
To: emacs-devel@gnu.org
Subject: `apply-partially' in subr.el is broken
Date: Mon, 20 Oct 2008 13:32:31 +0900	[thread overview]
Message-ID: <buo63nnevj4.fsf@dhapc248.dev.necel.com> (raw)

A recent change to subr.el uses a cl macro (lexical-let):

   2008-10-19  Eli Zaretskii  <eliz@gnu.org>

           * subr.el (apply-partially): Moved here from minibuffer.el.

apply-partially looks like:

   (defun apply-partially (fun &rest args)
     ...
     (lexical-let ((fun fun) (args1 args))
     ...

but subr.el does not have (eval-when-compile (require 'cl)).

Naturally, this does not compile correctly.

So either the require needs to be added or apply-partially needs to not
use lexical-let (is it ok for subr.el to use cl.el?).

Thanks,

-Miles

-- 
Congratulation, n. The civility of envy.




             reply	other threads:[~2008-10-20  4:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20  4:32 Miles Bader [this message]
2008-10-20  9:41 ` `apply-partially' in subr.el is broken Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buo63nnevj4.fsf@dhapc248.dev.necel.com \
    --to=miles.bader@necel.com \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).