unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* vc-toggle-read-only mishandles CVS ro file in presence of CVSREAD=1
@ 2008-06-25  5:04 Thien-Thi Nguyen
  2008-06-25  5:36 ` Miles Bader
  0 siblings, 1 reply; 8+ messages in thread
From: Thien-Thi Nguyen @ 2008-06-25  5:04 UTC (permalink / raw)
  To: emacs-devel

While investigating the pgg-gpg.el bug report (another thread), i
did a cvs update and now `C-x C-q' bleats on a CVS-controlled
read-only file (w/ env var `CVSREAD' set to "1").  This used to
work before, so i consider the current situation a regression.

I see vc-toggle-read-only now reads:

| (defun vc-toggle-read-only (&optional verbose)
|   "Change read-only status of current buffer, perhaps via version control.
| 
| If the buffer is visiting a file registered with version control,
| throw an error, because this is not a safe or really meaningful operation
| on any version-control system newer than RCS.
| 
| Otherwise, just change the read-only flag of the buffer.
| 
| If you bind this function to \\[toggle-read-only], then Emacs
| will properly intercept all attempts to toggle the read-only flag
| on version-controlled buffer."
|   (interactive "P")
|   (if (vc-backend buffer-file-name)
|       (error "Toggling the readability of a version controlled file is likely to wreak havoc.")
|     (toggle-read-only)))

The "not a safe ... newer than RCS" blurb is (gratuitously) wrong,
but at least we know the authors' bias up front.  I suggest we
remove that blurb and use checkout-model info to make this command
DTRT again.

thi




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-07-23 10:02 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-25  5:04 vc-toggle-read-only mishandles CVS ro file in presence of CVSREAD=1 Thien-Thi Nguyen
2008-06-25  5:36 ` Miles Bader
2008-06-25  9:35   ` Thien-Thi Nguyen
2008-06-25 14:10     ` Miles Bader
2008-06-25 14:40       ` Thien-Thi Nguyen
2008-07-23 10:02         ` Thien-Thi Nguyen
2008-06-25 15:48       ` Stefan Monnier
2008-06-25 16:27         ` Thien-Thi Nguyen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).