From: Miles Bader <miles@lsi.nec.co.jp>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [miles@lsi.nec.co.jp: redisplay abort if GLYPH_DEBUG turned on]
Date: Thu, 06 Jan 2005 11:29:49 +0900 [thread overview]
Message-ID: <buo3bxfz3vm.fsf@mctpc71.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <m33bxfwxd8.fsf@kfs-l.imdomain.dk> (Kim F. Storm's message of "Wed, 05 Jan 2005 19:21:07 +0100")
storm@cua.dk (Kim F. Storm) writes:
> There are other places which set stop_charpos to 0, so
> there is IT_CHARPOS <= stop_charpos is not an invariant.
>
> So Miles' change to the xassert is ok. But the comment need to be modified
> as well.
The thing that makes me nervous is that there seem to also be other
similar xasserts, e.g. [xdisp.c:2727]:
xassert (STRINGP (it->string)
|| (it->stop_charpos >= BEGV
&& it->stop_charpos >= IT_CHARPOS (*it)));
and [xdisp.c:4068]:
xassert (it->stop_charpos >= BEGV
&& it->stop_charpos <= it->end_charpos);
implying that there _are_ some sorts of rules for stop_charpos, but I
have no idea what they are. [I haven't had any crashes involving these
other xasserts.]
-Miles
--
Love is a snowmobile racing across the tundra. Suddenly it flips over,
pinning you underneath. At night the ice weasels come. --Nietzsche
next parent reply other threads:[~2005-01-06 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Cm1td-0003LC-VL@fencepost.gnu.org>
[not found] ` <m33bxfwxd8.fsf@kfs-l.imdomain.dk>
2005-01-06 2:29 ` Miles Bader [this message]
2005-01-06 19:56 ` [miles@lsi.nec.co.jp: redisplay abort if GLYPH_DEBUG turned on] Richard Stallman
2005-01-06 21:55 ` Kim F. Storm
2005-01-07 13:17 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buo3bxfz3vm.fsf@mctpc71.ucom.lsi.nec.co.jp \
--to=miles@lsi.nec.co.jp \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).