unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles.bader@necel.com>
Cc: emacs-devel@gnu.org
Subject: Re: Problem report #8 FALSE
Date: Mon, 10 Apr 2006 19:19:36 +0900	[thread overview]
Message-ID: <buo1ww520nb.fsf@dhapc248.dev.necel.com> (raw)
In-Reply-To: <200604100955.k3A9t1cP028530@coolsville.localdomain> (Jan D.'s message of "Mon, 10 Apr 2006 11:55:01 +0200 (CEST)")

"Jan D." <jan.h.d@swipnet.se> writes:
>> 4343 	          if (actual_format == 32 && actual_format < BITS_PER_LONG)
>> 4344 	            {
>
> It can not be < 32 if BITS_PER_LONG is 32, that is true.  But for a 64-bit CPU
> BITS_PER_LONG is 64, so then it becomes relevant.  It is only intended
> to be relevant for the BITS_PER_LONG == 64 case.
>
> I think gcc optimizes the code away if it finds that
> actual_format < BITS_PER_LONG can never be true.

Then perhaps rewriting the test as:

   if (actual_format == 32 && BITS_PER_LONG > 32)

would get rid of the warning (the checker should treat comparisons of
constants with constants as being uninteresting, as they're almost
always due to cpp macros like this).

It would probably also virtually ensure that gcc optimizes away the
code in the 32-bit BITS_PER_LONG case.

-Miles
-- 
Do not taunt Happy Fun Ball.

  reply	other threads:[~2006-04-10 10:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-09  6:59 Problem report #8 Dan Nicolaescu
2006-04-09 17:37 ` Chong Yidong
2006-04-09 18:32   ` Dan Nicolaescu
2006-04-09 22:29     ` Richard Stallman
2006-04-10  1:09       ` Dan Nicolaescu
2006-04-10  9:55 ` Problem report #8 FALSE Jan D.
2006-04-10 10:19   ` Miles Bader [this message]
2006-04-13 12:36 ` Problem report #8 Kenichi Handa
2006-04-13 23:47   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buo1ww520nb.fsf@dhapc248.dev.necel.com \
    --to=miles.bader@necel.com \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).