From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: propose: dired-isearch.el --- isearch in Dired Date: Wed, 08 Aug 2007 17:16:24 +0900 Message-ID: References: <874pjaiv45.fsf@gmail.com> Reply-To: Miles Bader NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1186561037 868 80.91.229.12 (8 Aug 2007 08:17:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2007 08:17:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 10:17:15 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IIgjA-00085o-8d for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2007 10:17:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IIgj9-0001PR-Oe for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2007 04:17:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IIgiV-00012z-7B for emacs-devel@gnu.org; Wed, 08 Aug 2007 04:16:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IIgiT-00011h-6a for emacs-devel@gnu.org; Wed, 08 Aug 2007 04:16:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IIgiS-00011Y-Pk for emacs-devel@gnu.org; Wed, 08 Aug 2007 04:16:28 -0400 Original-Received: from tyo202.gate.nec.co.jp ([202.32.8.206]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IIgiR-0007CR-EK; Wed, 08 Aug 2007 04:16:27 -0400 Original-Received: from relay21.aps.necel.com ([10.29.19.50]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id l788GMdR014861; Wed, 8 Aug 2007 17:16:25 +0900 (JST) Original-Received: from relay21.aps.necel.com ([10.29.19.16] [10.29.19.16]) by relay21.aps.necel.com with ESMTP; Wed, 8 Aug 2007 17:16:25 +0900 Original-Received: from dhapc248.dev.necel.com ([10.114.98.116] [10.114.98.116]) by relay21.aps.necel.com with ESMTP; Wed, 8 Aug 2007 17:16:24 +0900 Original-Received: by dhapc248.dev.necel.com (Postfix, from userid 31295) id 106533D0; Wed, 8 Aug 2007 17:16:24 +0900 (JST) System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: <874pjaiv45.fsf@gmail.com> (William Xu's message of "Wed\, 08 Aug 2007 12\:05\:30 +0900") Original-Lines: 25 X-Detected-Kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76188 Archived-At: A style question: Is there a reason you're using catch/throw instead of just directly testing the result of get-text-property? The latter seems both more efficient and more clear: (let ((V ...)) (catch 'return (while V (when COND (throw 'return V)) (setq V ...)))) => (let ((V ...)) (while (and V (not COND)) (setq V ...)) V) Thanks, -miles -- `Suppose Korea goes to the World Cup final against Japan and wins,' Moon said. `All the past could be forgiven.' [NYT]