unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, dancol@dancol.org
Cc: emacs-devel@gnu.org
Subject: RE: Why is custom--inhibit-theme-enable not t by default?
Date: Tue, 12 Jun 2018 12:54:20 -0700 (PDT)	[thread overview]
Message-ID: <bf485ec3-941a-4bb0-8f6e-25525a740431@default> (raw)
In-Reply-To: <<83vaao3qrn.fsf@gnu.org>>

> > > I think themes are special in this regard: loading a theme activates
> > > it.
> >
> > Why did we do it that way?
> 
> History, I guess.  AFAIR, it always has been that way.  Maybe we did
> it for compatibility with themes that were available outside of Emacs
> before Emacs supported themes?

No, not if you mean color themes (`color-theme.el'). Loading
them does _not_ activate them.  There are explicit functions
for installing a color theme and invoking (activating) it.

(And unlike the case for custom themes, you can undo the
application of a color theme.)

http://www.nongnu.org/color-theme/

http://download.savannah.nongnu.org/releases/color-theme/

> Or maybe because [custom] themes are just giant
> series of variable settings?

That's possible.  Initially, custom themes were just
variable settings, IIRC - there was no attempt to
imitate color themes.  Later, Chong Yidong added such
imitation.

> I really don't know.  We have this commentary in custom.el:
> 
>   ;; Each theme is stored in a theme file, with filename THEME-theme.el.
>   ;; Loading a theme basically involves calling (load "THEME-theme")
>   ;; This is done by the function `load-theme'.  Loading a theme
>   ;; automatically enables it.
> 
> You will see that load-theme reads the file, then evaluates the
> buffer, so 'load' will do the same.
> 
> > Is it too late to change it? Loading _anything_ shouldn't activate
> > it. I don't see a need to carve out a special case for themes.

Yes.



  parent reply	other threads:[~2018-06-12 19:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  4:14 Why is custom--inhibit-theme-enable not t by default? dancol
2018-06-12 15:23 ` Eli Zaretskii
2018-06-12 15:42   ` dancol
2018-06-12 16:37     ` Eli Zaretskii
     [not found]     ` <<83vaao3qrn.fsf@gnu.org>
2018-06-12 19:54       ` Drew Adams [this message]
2018-06-13 13:47         ` Basil L. Contovounesios
2018-06-13 14:22           ` Drew Adams
2018-06-13 16:55             ` Disabling custom themes (was: Why is custom--inhibit-theme-enable not t by default?) Basil L. Contovounesios
2018-06-13 17:16               ` Drew Adams
2018-06-13 17:21                 ` Disabling custom themes Eric Abrahamsen
2018-06-13 17:30                   ` Daniel Colascione
2018-06-14  2:34             ` Why is custom--inhibit-theme-enable not t by default? Richard Stallman
2018-06-14  3:26               ` Stefan Monnier
2018-06-14 14:21                 ` Drew Adams
2018-06-14 18:02                   ` Stefan Monnier
2018-06-14 18:16                     ` Drew Adams
2018-06-14 18:30                       ` Stefan Monnier
2018-06-14 18:41                         ` Basil L. Contovounesios
2018-06-14 20:09                           ` Stefan Monnier
2018-06-13 14:01     ` Basil L. Contovounesios
2018-06-17 21:31     ` Andy Moreton
2018-06-18 14:07       ` Andy Moreton
2018-06-19 14:49         ` Daniel Colascione
2018-06-12 18:24   ` Basil L. Contovounesios
2018-06-13  2:16   ` Richard Stallman
2018-06-13 13:56     ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf485ec3-941a-4bb0-8f6e-25525a740431@default \
    --to=drew.adams@oracle.com \
    --cc=dancol@dancol.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).