From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: vc-state and unregistered Date: Sun, 24 Apr 2016 23:43:31 +0300 Message-ID: References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87bn57otja.fsf_-_@gmx.de> <515b3451-820d-ad50-8c98-d0330a0f4266@yandex.ru> <87lh4arpbg.fsf@gmx.de> <87ega2rodp.fsf@gmx.de> <87vb37ury1.fsf@gmx.de> <87potfuqdt.fsf@gmx.de> <557a2987-39e8-051e-55fd-678bc01a6a40@yandex.ru> <87lh43upd9.fsf@gmx.de> <80b86343-9324-1de0-e66c-a02e80467740@yandex.ru> <87k2jmzxh5.fsf@gmx.de> <27facefd-4eb5-fa1f-4d72-66ac160c5478@yandex.ru> <87pote94m7.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1461530637 7946 80.91.229.3 (24 Apr 2016 20:43:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 20:43:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 22:43:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auQsi-00014q-Aq for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 22:43:52 +0200 Original-Received: from localhost ([::1]:56588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auQsh-0006Ca-N3 for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 16:43:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auQsT-00069u-4v for emacs-devel@gnu.org; Sun, 24 Apr 2016 16:43:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auQsP-0003DS-Vo for emacs-devel@gnu.org; Sun, 24 Apr 2016 16:43:37 -0400 Original-Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auQsP-0003D2-OG for emacs-devel@gnu.org; Sun, 24 Apr 2016 16:43:33 -0400 Original-Received: by mail-wm0-x243.google.com with SMTP id w143so16517345wmw.3 for ; Sun, 24 Apr 2016 13:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=5LM81F83uxdcq17qtgqi1Qfc68m6Md4+665krYOPjBg=; b=M0MhVIHxE+VpTfciWsTPdWrxF6XUyB1OJZujEmyCX2jaJ1t2k172vCMUN5jCjP8Or2 GcoQkwRLpodQvXo3rDJTn6S+baKsAiXL198JXy+OKrBUXZWakRgC4dSTUowjuflBFb44 rMPE2IWLeiPJtNY+gqFKIB+gHl8R0QKg4g4GxuUCISdx6ELpQUYRCAvOhE75fNA6fM90 QDfTfAuXk7pIp8TrHupIFW+sR6y6Z1juRvww2cyl9FKyA3szgCGPwSnNWIAEFKUx7wOR OOl4SeSzQoexB9gr88G8S5G5LdoFuYmHl8uIRgWTsRpXYTCyGlvjKHPIFsn+dMplyNqX 2e8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=5LM81F83uxdcq17qtgqi1Qfc68m6Md4+665krYOPjBg=; b=E6CBMkzZvc9VUjyT/JSq5ZDSCn1h+x0mj24wwseFNs+gNUoTDeDSJsGbJOM+kuc4yo y3GujvRwb+q0HmVpKPCpFYpyu/0Vj6YT6V9gKzk9XwB/Wbc1iYXkb3xIHZnXi1LbOYyJ jGb8r2zgCHn8A2Eox4nss2oLRbuqVhaj82lmzsjnT95oC7J6gSJWVnA0RAHPx42whThg zsoA6hTVaoZO67ExM6XxIJ7RbwYOcCtvk/mPIorrc615IMGQFwbalY5qoubA+o+ECsIm WkoQHu/uDS5Zyk5bXdjY0bj5yMOoqZdHpsNxusDAemz6nJaV8ec4S/iiYkPLrGbLxOMk U41w== X-Gm-Message-State: AOPr4FVsVp8/ow/eomSzKq/HPkMjXw0T+bQ7OgSfa66woUWCGCpqKHQKTWdQuyL9BBL6TQ== X-Received: by 10.194.5.132 with SMTP id s4mr25483994wjs.118.1461530613118; Sun, 24 Apr 2016 13:43:33 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id e12sm15346243wma.15.2016.04.24.13.43.31 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2016 13:43:32 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87pote94m7.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203279 Archived-At: On 04/24/2016 10:41 PM, Michael Albinus wrote: >> And if buffer-file-name is outside of any version control, does your >> version of vc-state return nil? > > No. I didn't test this. As said, the tests must be improved, that's what > they are good for. And bugs must be fixed. We could add a separate test for that, but the simplest fix would require updating the existing tests as well, and then that test wouldn't be necessary. See the commit I pushed. Anyway, feel free to add it. We didn't finish the discussion about semantics, so it didn't seem proper to me to add tests for them. > But for the other cases, files under version control, my last commits > have shown improvements I believe. That's why I find your reaction to > revert everything ... annoying. Not everything, just the parts that conflicted with the patch I've sent previously. Which I had to recreate. So in the interest of speed, I've also removed all (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) checks. They aren't essential, and finding which of them are failing exactly is too time-consuming. Let's only add each of them back after they pass. I'd also like to have the different steps of each scenario as separate tests, so that ERT can tell us which failed.