From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: What's the line length limit in the Emacs codebase? Date: Sat, 26 Dec 2020 10:43:29 -0800 (PST) Message-ID: References: <83wnx8pm0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Emacs developers To: Philipp Stephani , Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 26 19:44:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktEYC-0007Zu-Hw for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 19:44:24 +0100 Original-Received: from localhost ([::1]:54266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktEYB-0000t0-I8 for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 13:44:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktEXS-0000Tu-Nf for emacs-devel@gnu.org; Sat, 26 Dec 2020 13:43:38 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:56036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktEXQ-0007Wb-Mw; Sat, 26 Dec 2020 13:43:38 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BQIZMxZ110681; Sat, 26 Dec 2020 18:43:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=3SRmt/lP/sLc/nuQKl18Y1LNvOJcyQ2KelUt/owocyg=; b=yz7XgX7nvU4XxQESqdHx4BLBIQ0TuNf2b81sZGhOXnLeBE+JOqklZgDJ8rqPLtNiwOnE 1hd6X17Gw+cs4zPyMP+7n+ysPWLV07PVCHOpIgaeRXxJNln343jBfukwSP9MwPU/znXo YP93nlTe5Q+kTjzfJmBuspzo4RrYUTdtblC6O1uptNqX/k/6zcjUUeLUdmzASSNQnHor hnGY5U0j4MB9XxuRToLf4O+wRJkEiIKIv0NUUqzHJMxeikIyTU8+OwVYKGz6/kNCVy0K w+6i8J0sJPDkh9fjk6juTTU6Ok9VudTUkZ+UahHo0urq1slvaOaEGgHQW2mpa3kMYVET Xw== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 35nvkqguwv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 26 Dec 2020 18:43:33 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BQIUld5154772; Sat, 26 Dec 2020 18:43:33 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 35nt9r5bh1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 26 Dec 2020 18:43:32 +0000 Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BQIhVTq017094; Sat, 26 Dec 2020 18:43:32 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5095.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9846 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012260127 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9846 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012260127 Received-SPF: pass client-ip=156.151.31.86; envelope-from=drew.adams@oracle.com; helo=userp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261863 Archived-At: > I don't think we should reformat existing code, that just adds > annoying whitespace changes that make 'git blame' etc. unnecessarily > hard. This has always been the argument. My opinion doesn't count here, as I don't often diff versions of the source code etc. But the downside to avoiding such refactoring (yes, it's a kind of refactoring, but it should have no semantic import) is that the code gets messier, not cleaner. Presumably however, such whitespace-only changes would typically be once-only. (But sure, diffs with any pre-change versions would have the noise problem.) ___ That said, I don't have a problem with long lines, personally. The main advantage I personally see for short lines is when I copy them into web pages, emails, etc. when trying to help others or otherwise communicate in contexts where the "box" for code has limited width, and so wraps or requires horizontal scrolling when lines are wider than the box.