From: Drew Adams <drew.adams@oracle.com>
To: Philipp Stephani <p.stephani2@gmail.com>, Richard Stallman <rms@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: RE: What's the line length limit in the Emacs codebase?
Date: Sat, 26 Dec 2020 10:43:29 -0800 (PST) [thread overview]
Message-ID: <bca81e08-565f-4cda-805c-2c18c494c205@default> (raw)
In-Reply-To: <CAArVCkSBwYS=2UzMYC0yMsGQY_zEbjg4bemV1Nw6OpU9rd=4Vw@mail.gmail.com>
> I don't think we should reformat existing code, that just adds
> annoying whitespace changes that make 'git blame' etc. unnecessarily
> hard.
This has always been the argument.
My opinion doesn't count here, as I don't often diff
versions of the source code etc.
But the downside to avoiding such refactoring (yes,
it's a kind of refactoring, but it should have no
semantic import) is that the code gets messier, not
cleaner.
Presumably however, such whitespace-only changes
would typically be once-only. (But sure, diffs
with any pre-change versions would have the noise
problem.)
___
That said, I don't have a problem with long lines,
personally.
The main advantage I personally see for short lines
is when I copy them into web pages, emails, etc. when
trying to help others or otherwise communicate in
contexts where the "box" for code has limited width,
and so wraps or requires horizontal scrolling when
lines are wider than the box.
prev parent reply other threads:[~2020-12-26 18:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 9:58 What's the line length limit in the Emacs codebase? Philipp Stephani
2020-12-23 15:42 ` Eli Zaretskii
2020-12-23 16:55 ` Stefan Monnier
2020-12-23 21:21 ` Karl Fogel
2020-12-24 3:37 ` Eli Zaretskii
2020-12-25 17:11 ` Philipp Stephani
2020-12-25 17:43 ` Stefan Monnier
2020-12-26 11:02 ` Philipp Stephani
2020-12-26 16:30 ` Stefan Monnier
2020-12-27 5:38 ` Richard Stallman
2020-12-25 20:32 ` tomas
2020-12-26 10:38 ` Michael Albinus
2020-12-26 11:17 ` Yuri Khan
2020-12-26 11:22 ` Michael Albinus
2020-12-26 11:36 ` Yuri Khan
2020-12-26 12:21 ` tomas
2020-12-26 18:31 ` Drew Adams
2020-12-26 11:12 ` Philipp Stephani
2020-12-25 17:10 ` Philipp Stephani
2020-12-25 19:04 ` Eli Zaretskii
2020-12-26 11:09 ` Philipp Stephani
2020-12-26 11:14 ` Eli Zaretskii
2020-12-26 10:24 ` Richard Stallman
2020-12-26 11:04 ` Philipp Stephani
2020-12-26 18:43 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca81e08-565f-4cda-805c-2c18c494c205@default \
--to=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).