From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Cully via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] new package: tramp-docker Date: Sat, 24 Sep 2022 13:31:17 -0400 Message-ID: References: <5674f36a-c276-fd77-b4d2-1525c75a1602@spork.org> <87y1uarnhu.fsf@gmx.de> <63d5f29a-05ed-f8c5-796c-a6eb9e28d575@spork.org> <87tu4yrmwi.fsf@gmx.de> <87mtaqrmio.fsf@gmx.de> <87h70xrrgi.fsf@gmx.de> <44bd6537-316c-acc7-a4d6-6123bc32e2c0@spork.org> <878rm8soce.fsf@gmx.de> Reply-To: Brian Cully Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9187"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 24 19:32:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oc91G-0002BI-Ar for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Sep 2022 19:32:52 +0200 Original-Received: from localhost ([::1]:33694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oc91E-00026Y-O7 for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Sep 2022 13:32:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc907-0001PM-EA for emacs-devel@gnu.org; Sat, 24 Sep 2022 13:31:39 -0400 Original-Received: from coleridge.kublai.com ([166.84.7.167]:60415 helo=mail.spork.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc906-0003LX-07 for emacs-devel@gnu.org; Sat, 24 Sep 2022 13:31:39 -0400 Original-Received: from [192.168.1.5] (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id 9568F9D69; Sat, 24 Sep 2022 13:31:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1664040685; bh=mLvr/qHcD3i9rYcQeaC6F012uPrYfPbJ44Q/PieACVU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=G10d+0GXyw9ChZ5NPLC795K5OUeAf5yEofnDVn9XtWCRkrPuu4wUALMPqxVBQZLx1 YxQdq9865oa1XU8Zbz7wJ1niPrE/C3bqYHKm789BIRMKDpyyxHUVkrB/k4Xia+m1Bw keDs1sWuX5D2PvGstitHUNjKaiE0aKeBlcI2fraI= Content-Language: en-US In-Reply-To: <878rm8soce.fsf@gmx.de> Received-SPF: pass client-ip=166.84.7.167; envelope-from=bjc@spork.org; helo=mail.spork.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.118, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296175 Archived-At: On 9/24/22 12:56, Michael Albinus wrote: > OK, done. tramp-docker.el exists now in both the Tramp and Emacs > repositories. Please check my changes, whether everything looks proper > to you. Looks good at first glance. I don't really have time to check functionality right now, but nothing stands out. > Another question: You have > > --8<---------------cut here---------------start------------->8--- > (tramp-login-args (("exec") > ("-it") > ("-u" "%u") > ("%h") > ("/bin/sh"))) > (tramp-remote-shell "/bin/sh") > --8<---------------cut here---------------end--------------->8--- > > Are you sure, that /bin/sh will always exist in containers? No, I don't think it's possible to know that for sure. But I think Docker only supports *nix containers, in which case it's a reasonable assumption. Even Guix has /bin/sh and /usr/bin/env. > And shouldn't > we rather use tramp-default-remote-shell instead of hard-coding > "/bin/sh", for the benefit of customization? I wasn't aware of `tramp-default-remote-shell' at all, but it seems like that's what should be used rather than hardcoding the value. -bjc