* Re: [Emacs-diffs] master 3698c4e: * cl-generic.el (cl-defmethod): Make docstring dynamic
[not found] ` <20160712160406.974D5220147@vcs.savannah.gnu.org>
@ 2016-08-01 21:02 ` Ken Brown
2016-08-02 17:01 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Ken Brown @ 2016-08-01 21:02 UTC (permalink / raw)
To: emacs-devel, Stefan Monnier
On 7/12/2016 12:04 PM, Stefan Monnier wrote:
> branch: master
> commit 3698c4e475fb59730626af5d001599785ef5ef9e
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * cl-generic.el (cl-defmethod): Make docstring dynamic
>
> * lisp/emacs-lisp/cl-generic.el (cl-defmethod): Make docstring dynamic.
> (cl--generic-make-defmethod-docstring): New function for that.
> (cl-defmethod, cl-generic-generalizers): Tweak docstrings accordingly.
> (cl-generic-define-method, cl--generic-describe): Change `load-history'
> format of cl-defmethods, so as not to confused methods with equal
> specializers but different qualifiers.
> * lisp/emacs-lisp/eieio-core.el (cl-generic-generalizers): Provide docstrings.
I'm getting five test failures in elisp-mode-tests:
FAILED xref-elisp-test-find-defs-defgeneric-co-located-default
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defgeneric-implicit-generic
FAILED xref-elisp-test-find-defs-defgeneric-no-default
FAILED xref-elisp-test-find-defs-defgeneric-separate-default
A bisection points to this commit as the culprit.
Ken
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] master 3698c4e: * cl-generic.el (cl-defmethod): Make docstring dynamic
2016-08-01 21:02 ` [Emacs-diffs] master 3698c4e: * cl-generic.el (cl-defmethod): Make docstring dynamic Ken Brown
@ 2016-08-02 17:01 ` Stefan Monnier
2016-08-07 4:01 ` Ken Brown
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2016-08-02 17:01 UTC (permalink / raw)
To: emacs-devel
> I'm getting five test failures in elisp-mode-tests:
> FAILED xref-elisp-test-find-defs-defgeneric-co-located-default
> FAILED xref-elisp-test-find-defs-defgeneric-el
> FAILED xref-elisp-test-find-defs-defgeneric-implicit-generic
> FAILED xref-elisp-test-find-defs-defgeneric-no-default
> FAILED xref-elisp-test-find-defs-defgeneric-separate-default
> A bisection points to this commit as the culprit.
Should be fixed now. These tests are ugly.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] master 3698c4e: * cl-generic.el (cl-defmethod): Make docstring dynamic
2016-08-02 17:01 ` Stefan Monnier
@ 2016-08-07 4:01 ` Ken Brown
0 siblings, 0 replies; 3+ messages in thread
From: Ken Brown @ 2016-08-07 4:01 UTC (permalink / raw)
To: emacs-devel
On 8/2/2016 1:01 PM, Stefan Monnier wrote:
>> I'm getting five test failures in elisp-mode-tests:
>
>> FAILED xref-elisp-test-find-defs-defgeneric-co-located-default
>> FAILED xref-elisp-test-find-defs-defgeneric-el
>> FAILED xref-elisp-test-find-defs-defgeneric-implicit-generic
>> FAILED xref-elisp-test-find-defs-defgeneric-no-default
>> FAILED xref-elisp-test-find-defs-defgeneric-separate-default
>
>> A bisection points to this commit as the culprit.
>
> Should be fixed now.
Confirmed. Thanks.
Ken
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-07 4:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160712160406.32314.27649@vcs.savannah.gnu.org>
[not found] ` <20160712160406.974D5220147@vcs.savannah.gnu.org>
2016-08-01 21:02 ` [Emacs-diffs] master 3698c4e: * cl-generic.el (cl-defmethod): Make docstring dynamic Ken Brown
2016-08-02 17:01 ` Stefan Monnier
2016-08-07 4:01 ` Ken Brown
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).