unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: emacs-devel@gnu.org
Subject: Re: Default custom group
Date: Wed, 18 May 2005 15:18:50 +0900	[thread overview]
Message-ID: <b9yvf5hxdit.fsf@jpl.org> (raw)
In-Reply-To: E1DYGz1-0003eZ-AL@fencepost.gnu.org

>>>>> In <E1DYGz1-0003eZ-AL@fencepost.gnu.org> Richard Stallman wrote:

>     I got many warnings when compiling Gnus.  For instance:

>     smime.el:123:1:Warning: defgroup for `smime' fails to specify containing group

> I think that is a real bug.  This group should surely be put in
> a logical place in the hierarchy.

I'm sorry for insufficient information.  It was caused by the
following form which didn't specify the parent group.

(defgroup smime nil
  "S/MIME configuration.")

>     I think there might be customization groups which don't belong
>     to any parent groups except `emacs'.

> There should not be any such groups, except the first-level groups
> defined in cus-edit.el specifically for that purpose.

Yesterday, I changed my mind and added the ``:group 'something''
argument to every defgroup, defface and defcustom forms in which
it hasn't been specified in Gnus (the changes will be propagated
into the Emacs trunk after a while).  At that time, I felt like
to add some first-level groups (e.g., cryptograph, security, etc.)
is necessary.  However, I'm not positive to propose adding of
them since Gnus v5.11 supports not only Emacs CVS but also Emacs
20 and 21.

By the way, I noticed the new bytecomp doesn't warn to the
defcustom form in which the parent group is not specified.  For
example:

(let ((file (expand-file-name
	     (concat (make-temp-name "testing") ".el")
	     temporary-file-directory)))
  (with-temp-file file
    (insert "\
\(defgroup foo nil \"doc\")
\(defcustom bar nil \"doc\")
"))
  (byte-compile-file file)
  (delete-file file)
  (delete-file (concat file "c")))

  reply	other threads:[~2005-05-18  6:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-14 15:12 Default custom group Richard Stallman
2005-05-16  5:56 ` Katsumi Yamaoka
2005-05-17 21:23   ` Daniel Brockman
2005-05-18 22:45     ` Richard Stallman
2005-05-18  5:20   ` Richard Stallman
2005-05-18  6:18     ` Katsumi Yamaoka [this message]
2005-05-18 22:44       ` Richard Stallman
2005-05-18 23:00         ` Katsumi Yamaoka
2005-05-18 22:44       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9yvf5hxdit.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).