configure problem

configure problem

[Katsumi Yamaoka]

Hi,

2003-07-12  Richard M. Stallman  <rms@gnu.org>

	* configure.in [netbsd systems]: Define HAVE_CRTIN properly.

There is a problem that the change has not been applied in the
configure script yet.  So I ran autoconf 2.57, however the
following error occurred:

configure.in:50: error: possibly undefined macro: AC_DEFINE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

Here is a patch which has been confirmed by the NetBSD user.
I don't know why the AC_DEFINE macro is not expanded there,
though. :{

*** configure.in~	Mon Jul 14 22:00:19 2003
--- configure.in	Tue Jul 15 06:39:03 2003
***************
*** 223,229 ****
    *-*-netbsd* )
      opsys=netbsd
      if test -f /usr/lib/crti.o; then
!       AC_DEFINE(HAVE_CRTIN)
      fi
  
      case "${canonical}" in
--- 223,231 ----
    *-*-netbsd* )
      opsys=netbsd
      if test -f /usr/lib/crti.o; then
!       cat >>confdefs.h <<_ACEOF
! #define HAVE_CRTIN 1
! _ACEOF
      fi
  
      case "${canonical}" in

Re: configure problem

[Kenichi Handa]

In article <b9yvfu4z3q4.fsf@jpl.org>, Katsumi Yamaoka <yamaoka@jpl.org> writes:
> configure.in:50: error: possibly undefined macro: AC_DEFINE
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.

> Here is a patch which has been confirmed by the NetBSD user.
> I don't know why the AC_DEFINE macro is not expanded there,
> though. :{

The reason is described in the comment above this jambo
"case" statement as this:

dnl This used to use changequote, but, apart from `changequote is evil'
dnl per the autoconf manual, we can speed up autoconf somewhat by quoting
dnl the great gob of text.  Thus it's not processed for possible expansion.
dnl Just make sure the brackets remain balanced.

I think it's not good to handle confdefs.h directly in
configure.in.  It's the task of autoconf.  So, have about
this alternative change?

---
Ken'ichi HANDA
handa@m17n.org


*** configure.in.~1.343.~	Tue Jul 15 13:11:42 2003
--- configure.in	Tue Jul 15 15:45:56 2003
***************
*** 222,231 ****
    ## NetBSD ports
    *-*-netbsd* )
      opsys=netbsd
-     if test -f /usr/lib/crti.o; then
-       AC_DEFINE(HAVE_CRTIN)
-     fi
- 
      case "${canonical}" in
        alpha*-*-netbsd*)	machine=alpha ;;
        i[3456]86-*-netbsd*) machine=intel386 ;;
--- 222,227 ----
***************
*** 1168,1173 ****
--- 1164,1175 ----
  fi
  
  ]
+ 
+ if test "${opsys}" = "netbsd"; then
+   if test -f /usr/lib/crti.o; then
+     AC_DEFINE(HAVE_CRTIN)
+   fi
+ fi
  
  if test $unported = yes; then
    AC_MSG_ERROR([Emacs hasn't been ported to `${canonical}' systems.

Re: configure problem

[Katsumi Yamaoka]

Thanks Handa-san.  Please ignore my patch!

>>>>> In <200307150658.PAA14821@etlken.m17n.org>
>>>>>	Kenichi Handa <handa@m17n.org> wrote:

>> I don't know why the AC_DEFINE macro is not expanded there,
>> though. :{

> The reason is described in the comment above this jambo
> "case" statement as this:

> dnl This used to use changequote, but, apart from `changequote is evil'
> dnl per the autoconf manual, we can speed up autoconf somewhat by quoting
> dnl the great gob of text.  Thus it's not processed for possible expansion.
> dnl Just make sure the brackets remain balanced.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: configure problem

[Andreas Schwab]

Kenichi Handa <handa@m17n.org> writes:

|> In article <b9yvfu4z3q4.fsf@jpl.org>, Katsumi Yamaoka <yamaoka@jpl.org> writes:
|> > configure.in:50: error: possibly undefined macro: AC_DEFINE
|> >       If this token and others are legitimate, please use m4_pattern_allow.
|> >       See the Autoconf documentation.
|> 
|> > Here is a patch which has been confirmed by the NetBSD user.
|> > I don't know why the AC_DEFINE macro is not expanded there,
|> > though. :{
|> 
|> The reason is described in the comment above this jambo
|> "case" statement as this:
|> 
|> dnl This used to use changequote, but, apart from `changequote is evil'
|> dnl per the autoconf manual, we can speed up autoconf somewhat by quoting
|> dnl the great gob of text.  Thus it's not processed for possible expansion.
|> dnl Just make sure the brackets remain balanced.

I have now checked in this change:

	* configure.in: Temporarily leave quoting for AC_DEFINE.

--- configure.in.~1.343.~	2003-07-14 13:49:29.000000000 +0200
+++ configure.in	2003-07-15 10:04:52.000000000 +0200
@@ -222,9 +222,9 @@ case "${canonical}" in
   ## NetBSD ports
   *-*-netbsd* )
     opsys=netbsd
-    if test -f /usr/lib/crti.o; then
+    if test -f /usr/lib/crti.o; then]
       AC_DEFINE(HAVE_CRTIN)
-    fi
+[   fi
 
     case "${canonical}" in
       alpha*-*-netbsd*)	machine=alpha ;;

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."