From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel,gmane.emacs.w3m Subject: bogus change(s) in cl-macs.el Date: Fri, 19 Nov 2004 12:06:35 +0900 Organization: Emacsen advocacy group Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1100833655 7392 80.91.229.6 (19 Nov 2004 03:07:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2004 03:07:35 +0000 (UTC) Cc: emacs-w3m@namazu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 19 04:07:27 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CUz7O-0007Je-00 for ; Fri, 19 Nov 2004 04:07:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUzGG-0007vR-A2 for ged-emacs-devel@m.gmane.org; Thu, 18 Nov 2004 22:16:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUzG6-0007tu-2O for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:16:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUzG4-0007t8-NA for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:16:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUzG4-0007st-Jo for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:16:24 -0500 Original-Received: from [69.61.9.140] (helo=minsk.hostforweb.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CUz6m-0004gc-RA for emacs-devel@gnu.org; Thu, 18 Nov 2004 22:06:48 -0500 Original-Received: from localhost ([127.0.0.1]) by minsk.hostforweb.net with esmtpa (Exim 4.43) id 1CUz6l-0001sT-6G; Thu, 18 Nov 2004 22:06:47 -0500 Original-To: emacs-devel@gnu.org Mail-Followup-To: emacs-devel@gnu.org, emacs-w3m@namazu.org X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:IOzK5itqz0LrMCwKhSajMURooik= X-Hashcash: 1:20:041119:emacs-devel@gnu.org::33mPy+P2oi4i7sMx:000000000000000000000000000000000000000000ByAr X-Hashcash: 1:20:041119:emacs-w3m@namazu.org::O5/0lopAPSE3ZSi5:000000000000000000000000000000000000000000n4Q X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - minsk.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30061 gmane.emacs.w3m:4541 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30061 Hello, There are many changes made in the version 1.46 of cl-macs.el. revision 1.46 date: 2004/11/16 04:05:29; author: monnier; state: Exp; lines: +219 -225 Use make-symbol rather than gensym. (loop, cl-parse-loop-clause, defsetf): Use backquote. First of all, I protest strongly that such a big change has not been recorded on the ChangeLog file. Second, the change at least to the `labels' macro breaks emacs-w3m. Emacs-w3m uses some cl macros including `labels' in order to work together with the external w3m command asynchronously. The patch below should be applied. Third, I'm not sure whether a problem is limited only to it. *** cl-macs.el~ Tue Nov 16 21:54:14 2004 --- cl-macs.el Fri Nov 19 01:30:39 2004 *************** *** 1314,1320 **** \(fn ((FUNC ARGLIST BODY...) ...) FORM...)" (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment)) (while bindings ! (let ((var (make-symbol "--cl-var--"))) (push var vars) (push (list 'function* (cons 'lambda (cdar bindings))) sets) (push var sets) --- 1314,1320 ---- \(fn ((FUNC ARGLIST BODY...) ...) FORM...)" (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment)) (while bindings ! (let ((var (gensym))) (push var vars) (push (list 'function* (cons 'lambda (cdar bindings))) sets) (push var sets) Regards,