unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: emacs-w3m@namazu.org
Subject: bogus change(s) in cl-macs.el
Date: Fri, 19 Nov 2004 12:06:35 +0900	[thread overview]
Message-ID: <b9y4qjmwn9g.fsf@jpl.org> (raw)

Hello,

There are many changes made in the version 1.46 of cl-macs.el.

revision 1.46
date: 2004/11/16 04:05:29;  author: monnier;  state: Exp;  lines: +219 -225
Use make-symbol rather than gensym.
(loop, cl-parse-loop-clause, defsetf): Use backquote.

First of all, I protest strongly that such a big change has not
been recorded on the ChangeLog file.  Second, the change at least
to the `labels' macro breaks emacs-w3m.  Emacs-w3m uses some cl
macros including `labels' in order to work together with the
external w3m command asynchronously.  The patch below should be
applied.  Third, I'm not sure whether a problem is limited only
to it.

*** cl-macs.el~	Tue Nov 16 21:54:14 2004
--- cl-macs.el	Fri Nov 19 01:30:39 2004
***************
*** 1314,1320 ****
  \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
    (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment))
      (while bindings
!       (let ((var (make-symbol "--cl-var--")))
  	(push var vars)
  	(push (list 'function* (cons 'lambda (cdar bindings))) sets)
  	(push var sets)
--- 1314,1320 ----
  \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
    (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment))
      (while bindings
!       (let ((var (gensym)))
  	(push var vars)
  	(push (list 'function* (cons 'lambda (cdar bindings))) sets)
  	(push var sets)

Regards,

             reply	other threads:[~2004-11-19  3:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19  3:06 Katsumi Yamaoka [this message]
2004-11-19  3:41 ` bogus change(s) in cl-macs.el Luc Teirlinck
2004-11-19  3:51   ` Miles Bader
2004-11-19  4:21     ` Luc Teirlinck
2004-11-19  3:48 ` Miles Bader
2004-11-19  3:59   ` Katsumi Yamaoka
2004-11-19  5:55     ` [emacs-w3m:07185] " Katsumi Yamaoka
2004-11-19  7:10       ` Stefan Monnier
2004-11-19 20:04         ` Richard Stallman
2004-11-26  2:17         ` Katsumi Yamaoka
2004-11-26  4:03           ` Stefan Monnier
2004-11-26  5:18             ` Katsumi Yamaoka
2004-11-26 23:51         ` Stefan Monnier
2004-11-19  5:40 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9y4qjmwn9g.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=emacs-w3m@namazu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).