unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Spencer Baugh <sbaugh@catern.com>
To: emacs-devel@gnu.org
Cc: Spencer Baugh <sbaugh@catern.com>,
	Arnold Noronha <arnold@tdrhq.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Dmitry Gutov <dgutov@yandex.ru>
Subject: [PATCH v2 01/16] Add a test for let-binding unwinding
Date: Sat, 21 Nov 2020 21:34:30 -0500	[thread overview]
Message-ID: <b9b9479699729aaeb98b7280699d7f1e291322d8.1606009917.git.sbaugh@catern.com> (raw)
In-Reply-To: <cover.1606009917.git.sbaugh@catern.com>

Bindings in other buffers are not un-set when we unwind a let-binding
which set the default value.  There doesn't seem to be an existing
test which covers this, so here's one.
---
 test/src/data-tests.el | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/test/src/data-tests.el b/test/src/data-tests.el
index 1312683c84..7e69b9c331 100644
--- a/test/src/data-tests.el
+++ b/test/src/data-tests.el
@@ -364,6 +364,28 @@ comparing the subr with a much slower lisp implementation."
           (should (equal (default-value var) (symbol-value var))))
         (should (equal (default-value var) def))))))
 
+(ert-deftest data-tests--let-buffer-local-no-unwind-other-buffers ()
+  "Test that a let-binding for a buffer-local unwinds only current-buffer"
+  (let ((blvar (make-symbol "blvar")))
+    (set-default blvar 0)
+    (make-variable-buffer-local blvar)
+    (dolist (var (list blvar 'left-margin))
+      (let* ((def (default-value var))
+             (newdef (+ def 1))
+             (otherbuf (generate-new-buffer "otherbuf")))
+        (with-temp-buffer
+          (cl-progv (list var) (list newdef)
+            (with-current-buffer otherbuf
+              (set var 123)
+              (should (local-variable-p var))
+              (should (equal (symbol-value var) 123))
+              (should (equal (default-value var) newdef))))
+          (with-current-buffer otherbuf
+            (should (local-variable-p var))
+            (should (equal (symbol-value var) 123))
+            (should (equal (default-value var) def)))
+          )))))
+
 (ert-deftest binding-test-makunbound ()
   "Tests of makunbound, from the manual."
   (with-current-buffer binding-test-buffer-B
-- 
2.28.0




  reply	other threads:[~2020-11-22  2:34 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 16:34 ido-switch-buffer is slow with many buffers; others are fast catern
2020-11-14 18:22 ` Stefan Monnier
2020-11-14 20:06   ` sbaugh
2020-11-14 23:00     ` Stefan Monnier
2020-11-14 23:16 ` Dmitry Gutov
2020-11-15  0:19   ` Spencer Baugh
2020-11-15 15:15     ` Stefan Monnier
2020-11-15 20:49       ` Spencer Baugh
2020-11-15 23:58         ` Arnold Noronha
2020-11-19 15:38         ` [PATCH 00/10] Speeding up DEFVAR_PER_BUFFER (Was: ido-switch-buffer is slow) Spencer Baugh
2020-11-19 17:29           ` [PATCH 00/10] Speeding up DEFVAR_PER_BUFFER Stefan Monnier
2020-11-22  2:34           ` [PATCH v2 00/16] " Spencer Baugh
2020-11-22  2:34             ` Spencer Baugh [this message]
2020-11-25 20:53               ` [PATCH v2 01/16] Add a test for let-binding unwinding Stefan Monnier
2020-11-30 17:31                 ` Spencer Baugh
2020-12-01 16:44               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 02/16] Assert not local-variable-p after setq in let_default binding Spencer Baugh
2020-11-25 20:54               ` Stefan Monnier
2020-12-01 16:45               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 03/16] Stop checking the constant default for enable_multibyte_characters Spencer Baugh
2020-11-25 20:57               ` Stefan Monnier
2020-12-01 16:52               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 04/16] Take buffer field name in DEFVAR_PER_BUFFER Spencer Baugh
2020-12-01 16:56               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 05/16] Add BVAR_DEFAULT for access to buffer defaults Spencer Baugh
2020-12-01 17:00               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 06/16] Use bset_* functions instead of BVAR Spencer Baugh
2020-12-01 17:12               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 07/16] Take offset not idx in PER_BUFFER_VALUE_P Spencer Baugh
2020-12-01 17:20               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 08/16] Combine unnecessarily separate loops in buffer.c Spencer Baugh
2020-12-01 17:22               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 09/16] Add and use BUFFER_DEFAULT_VALUE_P Spencer Baugh
2020-12-01 17:24               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 10/16] Add and use KILL_PER_BUFFER_VALUE Spencer Baugh
2020-12-01 17:26               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 11/16] Assert that PER_BUFFER_IDX for Lisp variables is not 0 Spencer Baugh
2020-12-01 17:32               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 12/16] Rearrange set_internal for buffer forwarded symbols Spencer Baugh
2020-12-01 17:35               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 13/16] Get rid of buffer_permanent_local_flags array Spencer Baugh
2020-11-22 16:16               ` Eli Zaretskii
2020-12-01 17:39               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 14/16] Remove unnecessary Qunbound check Spencer Baugh
2020-12-01 17:40               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 15/16] Remove local_flags array in struct buffer Spencer Baugh
2020-11-22 20:04               ` Stefan Monnier
2020-12-01 17:57               ` Eli Zaretskii
2020-11-22  2:34             ` [PATCH v2 16/16] Remove usage of buffer_local_flags Spencer Baugh
2020-12-01 18:05               ` Eli Zaretskii
2020-11-22 11:19             ` [PATCH v2 00/16] Speeding up DEFVAR_PER_BUFFER Kévin Le Gouguec
2020-11-22 16:12             ` Eli Zaretskii
2020-11-22 16:28               ` Spencer Baugh
2020-11-22 17:13                 ` Eli Zaretskii
2020-11-29 17:41                   ` Spencer Baugh
2020-11-30 18:32                     ` Eli Zaretskii
2020-11-30 20:11                       ` Spencer Baugh
2020-11-30 22:10                         ` Stefan Monnier
2020-11-30 22:26                           ` Andrea Corallo via Emacs development discussions.
2020-12-01 15:15                           ` Eli Zaretskii
2020-12-01 15:56                             ` Stefan Monnier
2020-12-01 15:10                         ` Eli Zaretskii
2020-12-01 15:20                           ` Spencer Baugh
2020-12-01 16:01                           ` Stefan Monnier
2020-12-01 16:16                             ` Eli Zaretskii
2020-12-01 18:10                       ` Eli Zaretskii
2020-11-22 20:11                 ` Stefan Monnier
2020-11-19 15:38         ` [PATCH 01/10] Take buffer field name in DEFVAR_PER_BUFFER Spencer Baugh
2020-11-19 15:38         ` [PATCH 02/10] Add bset_save_length and use it Spencer Baugh
2020-11-19 15:38         ` [PATCH 03/10] Use bset_last_selected_window everywhere Spencer Baugh
2020-11-19 15:38         ` [PATCH 04/10] Use bset_enable_multibyte_characters everywhere Spencer Baugh
2020-11-19 15:38         ` [PATCH 05/10] Add BVAR_DEFAULT for access to buffer defaults Spencer Baugh
2020-11-19 15:38         ` [PATCH 06/10] Disallow using BVAR as an lvalue Spencer Baugh
2020-11-19 15:38         ` [PATCH 07/10] Reorder buffer.h for upcoming rework of BVAR Spencer Baugh
2020-11-19 15:38         ` [PATCH 08/10] Make cache_long_scans buffer-local when setting it Spencer Baugh
2020-11-19 15:38         ` [PATCH 09/10] Access buffer_defaults in BVAR if there's no local binding Spencer Baugh
2020-11-19 18:08           ` Stefan Monnier
2020-11-19 18:21             ` Eli Zaretskii
2020-11-19 15:38         ` [PATCH 10/10] Don't iterate over all buffers in set_default_internal Spencer Baugh
2020-11-19 18:21           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9b9479699729aaeb98b7280699d7f1e291322d8.1606009917.git.sbaugh@catern.com \
    --to=sbaugh@catern.com \
    --cc=arnold@tdrhq.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).