From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4a1e97b: New user option for Git log switches Date: Fri, 11 Jun 2021 04:40:40 +0300 Message-ID: References: <20210608233619.8439.15341@vcs0.savannah.gnu.org> <20210608233620.E895F209C6@vcs0.savannah.gnu.org> <875yyn2st3.fsf@gmx.de> <87o8ceuq9l.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24257"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: Utkarsh Singh , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 11 03:41:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrWAw-0006DU-Mf for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 03:41:34 +0200 Original-Received: from localhost ([::1]:38390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrWAv-0005IG-Ku for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 21:41:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrWA9-0004WE-IX for emacs-devel@gnu.org; Thu, 10 Jun 2021 21:40:47 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:51076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrWA7-0001Cl-LL for emacs-devel@gnu.org; Thu, 10 Jun 2021 21:40:45 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id d184so7213885wmd.0 for ; Thu, 10 Jun 2021 18:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G9uzO0pAySCo+Xr2hXiNo1AjTmNodbrqRjSxrMI1dmY=; b=UwMqNDge7vRCfqG6B9GR0JSBALGOsR+D8z5xd3lNiC5r3HWOpgdssqnivlobXklL8J E6eYM12e4m8LEF8fjSyQ5SEnNEQZhPVeK/6RqR4NNUJKvGxtRmpnB0PWFh7MDKrtkceh tzafPePTBLUSfWzGEEAxTQBDmOBvkxIx33Llt5427aBANnfCRe8L+i6oJZJQcB+U9hOl e1zGvt4NXkPhGLE2fyeCU3J19bbJcpmlVtvf6rXUeZDEyCEgGi/r2K3cpcLAtFaObMaT unMNdM/px95oKqyw56fLpHs82bScG1ZGC1G5KQAw5UIBeRoh3hUt8T7KJ6T1nuAkOqNS HZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G9uzO0pAySCo+Xr2hXiNo1AjTmNodbrqRjSxrMI1dmY=; b=F5kELbit9/20DF9DJRCDiwRaR7VXxJtAyOouDfykWDKKTPXprFONekeOcnCLewSQno wA/dXvDmWnxGK/X2V4EsipsQs5Q0/5NWfsM6s2Ke5QxcZBx6yyi8afqjhw9yudou6fbd jtOpsZLyECLowT5t2Cir+4rvS3Zfs5um2cP42iOZ0BSGScnK2NaivJ9G9vRndt+jFEht p7dlb6UjuqZNVeBazwioYdnQL886kXMrhPaHPlD8654WCNCQnGwaOWwVK10sgRPAYuBQ J2pLbqbUYiMzSLZq5wt9msJb56F3FYWU9XkRNgUrXS9roeXOGaK3niP+NnYgey4a/hDB NeYA== X-Gm-Message-State: AOAM5302hrA4Rb/I8FXFp3RlLhM0vkEqXyBY7qyYuhOYBlkA5srLWSMP v0AyQzFjCkD+5MKllhTSY2k= X-Google-Smtp-Source: ABdhPJwRfAfp81IvZvo7PrVqQG9OOgHHKicoJOuBey7JoMCadO08mS/3n7ZHi7pWonigsji8nwUtJw== X-Received: by 2002:a05:600c:3ba2:: with SMTP id n34mr1423801wms.120.1623375642316; Thu, 10 Jun 2021 18:40:42 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v18sm5719258wrb.10.2021.06.10.18.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 18:40:41 -0700 (PDT) In-Reply-To: <87o8ceuq9l.fsf@gmx.de> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=raaahh@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270680 Archived-At: On 10.06.2021 10:34, Michael Albinus wrote: > Existing vc-*-diff-switches declare > > :type '(choice (const :tag "Unspecified" nil) > (const :tag "None" t) > (string :tag "Argument String") > (repeat :tag "Argument List" :value ("") string))) > > Existing vc-*-log-switches declare > > :type '(choice (const :tag "None" nil) > (string :tag "Argument String") > (repeat :tag "Argument List" :value ("") string))) Right, so it's either follow the example of existing vc-git*-switches options, or of vc-*-log-switches options. But to be frank the 'vc-annotate-switches' option is pretty useless, so the latter seems to be the better example. >> I figured it wouldn't be too bad to allow that possibility in the >> future, but you are probably right and we should simplify this. > > In favor of uniformity, vc-git-log-switches might follow the scheme. Now done in commit 86309efb4a. >> 'hg log' and 'git log' are pretty different after all. > > Sure. But we're speaking about defcustom types, aren't we? We were talking about whether having a possible value 't' is helpful for the discussed option. And that value allows delegating to a cross-backend variable, which is only useful when different backends can accept the same options.