From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Tue, 18 May 2021 18:17:04 +1000 Organization: By Dasein Message-ID: References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10386"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Purely Mail via Roundcube/1.4.10 Cc: Emacs Devel To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 18 10:18:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liuve-0002U0-L3 for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 10:18:15 +0200 Original-Received: from localhost ([::1]:35384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liuvd-00039B-Ln for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 04:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liuuk-00020V-K3 for emacs-devel@gnu.org; Tue, 18 May 2021 04:17:18 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:55378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liuui-0006n7-R5 for emacs-devel@gnu.org; Tue, 18 May 2021 04:17:18 -0400 DKIM-Signature: a=rsa-sha256; b=WGYCYzWdXiUKyd8b+PUM3b+/4FVgO1LMY1GxHt+WSk3AG9AMbFHCytq0sO9JXt9Hzb/ewo0vQikdCVIrITsS7oau+yDzErXuO+X693UGuicBIL8n6cdyNvKtEK1t8TR8dQmYtsVKITsRKVDl86BL9s0Ifl1uxA1E9iZNjR2K6g8jA2cR2YCSDWt7sDloeYt3WqB6be+HXiMiahHsIiZ3kqSnRZCr0liwyqQwroCoUdJSqQR7sSn4LMSi39R5t9jH5nVFrnQUNIWgz5f/tDyJNbQM/KMlvOs2XQJfdke0di4MxsSsNkgObYaULqodFNbBNkJxHwVQNiR8Aqc6HKB0DA==; s=purelymail3; d=bydasein.com; v=1; bh=wcU4WiP1giBe7QzZ8jSbArUNo9/XReG3A80rX8ZNbUE=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=G1sYXUFhCR5qnuw0CqFRRjNfCZMuUJDa1kBR+SBXQddtezkztS43NeAzA2V4LwZsCPhYNr7Uun2l6J/Z++DadekrlXhQDYgSgLKBVfyxjXRDs+sJI8m4ewEI+89WtmA4I45AkdqsafnV5kx/kWSOQ0GegUND0T3LRx/N86cgd3OAqgyJffnPdcemHZm7Z1wD5BuBctmVXVVGtp/mgZsL2Rh7LpG0b6y3QYH2Abjuc6hZL2Bt3sfgI6xA5fbZGBOXyetP9hBgjaV2Nm8Hte4TYZTOgwh4HNptvzyZR8d/+VF0ZF7K0u7ZFNAGhx3zZLWS5Yyjow4uV78w1NB7laE7yw==; s=purelymail3; d=purelymail.com; v=1; bh=wcU4WiP1giBe7QzZ8jSbArUNo9/XReG3A80rX8ZNbUE=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-164.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -2078905589; Tue, 18 May 2021 08:17:04 +0000 (UTC) In-Reply-To: <87k0nw1qaq.fsf@red-bean.com> X-Sender: pwr@bydasein.com Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269435 Archived-At: On 2021-05-18 16:58, Karl Fogel wrote: > On 18 May 2021, Paul W. Rankin" via "Emacs development discussions. > wrote: >> Ugh. Not sure how this slipped into master but it is not a >> good/considerate idea to set default value of bookmark-fontify to t. >> >> If there are no reasonable objections I'll push this later today. > > I don't have a strong opinion either way, but if you're curious as to > where this came from, it was here: > > The discussion in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179 > is quite long, so it might be worth reading before reverting. Hi Karl, The discussion there only seems to account for compatibility with package bm.el, not the more general "avoid pushing your idea onto everyone" idea. And given the overlay is temporary, it's quite opaque for the average person to inspect it to see what's actually happening. It's so ugly my first thought was that something had broken rather than this was actually an intentional feature. I'm going to commit this without further discussion -- which hopefully should remind others to take the more considerate route when introducing new features!