From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 37940b3: min and max now return one of their arguments Date: Wed, 8 Mar 2017 10:47:23 -0800 Organization: UCLA Computer Science Department Message-ID: References: <20170307012700.3354.30219@vcs0.savannah.gnu.org> <20170307012701.1C05D23F1F@vcs0.savannah.gnu.org> <92047e08-5984-12f2-c285-4017fefac7a3@cs.ucla.edu> <87efy8188w.fsf@linux-m68k.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1488998886 8901 195.159.176.226 (8 Mar 2017 18:48:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2017 18:48:06 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 Cc: Glenn Morris , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 08 19:48:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clgcv-0001bG-JX for ged-emacs-devel@m.gmane.org; Wed, 08 Mar 2017 19:47:57 +0100 Original-Received: from localhost ([::1]:57913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clgd1-0005Zv-6F for ged-emacs-devel@m.gmane.org; Wed, 08 Mar 2017 13:48:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clgcW-0005Nu-RC for emacs-devel@gnu.org; Wed, 08 Mar 2017 13:47:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clgcR-0005ZR-Vm for emacs-devel@gnu.org; Wed, 08 Mar 2017 13:47:32 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40194) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clgcR-0005XS-Pq; Wed, 08 Mar 2017 13:47:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E1636160084; Wed, 8 Mar 2017 10:47:24 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Owh5jmbadg7x; Wed, 8 Mar 2017 10:47:24 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3EAF11600B5; Wed, 8 Mar 2017 10:47:24 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uR8pGZWPIwcW; Wed, 8 Mar 2017 10:47:24 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 26233160084; Wed, 8 Mar 2017 10:47:24 -0800 (PST) In-Reply-To: <87efy8188w.fsf@linux-m68k.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212845 Archived-At: On 03/08/2017 12:29 AM, Andreas Schwab wrote: > ??? You removed the documentation! Ah, sorry, right you are; I'd forgotten that. Thanks for restoring it. However, I don't understand the point of the code part of your change to minmax_driver. Since arithcompare already checks that its arguments are numbers or markers, it's redundant for minmax driver to do so as well, so CHECK_NUMBER_OR_FLOAT_COERCE_MARKER call that you added to arithcompare will slow Emacs down slightly. Is there some reason why the slower code is necessary?