From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Additional cleanup around xterm-mouse Date: Sun, 15 Nov 2020 22:29:20 -0800 Message-ID: Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Roundcube Webmail/1.3.15 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 16 07:30:25 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keY1x-000799-JI for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 07:30:25 +0100 Original-Received: from localhost ([::1]:40754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keY1w-0003zx-Gk for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 01:30:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keY0y-0003Xd-NH for emacs-devel@gnu.org; Mon, 16 Nov 2020 01:29:24 -0500 Original-Received: from greenhill.hpalace.com ([2600:3c01::f03c:91ff:fe73:2daa]:40176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keY0w-0001dq-OG; Mon, 16 Nov 2020 01:29:24 -0500 Original-Received: from mail.finder.org (greenhill.hpalace.com [IPv6:2600:3c01::f03c:91ff:fe73:2daa]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 64EF75EF; Mon, 16 Nov 2020 06:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=finder.org; s=2018; t=1605508160; bh=QFN6mH0uYfkR/0ZgIq8eiEUxxuUnwuBQSPVLE4GWh0Q=; h=Date:From:To:Cc:Subject:From; b=naOfdh9YkX5OXipqXsVGfS3O1WeVHOI5SHEN1bFNJ6oDwSDegj8BS0tppRLWxf8vA Ba5t2d58wpmOO4N6Nbe+nSy0U2I4fQj1h9TPlq/DfFQUhfhm5O3qJPq68C6SRc+2V7 0V7A/iQwlTlWNUyuLivvjwMTW+cGrgsCflaJPTLXLETWjpzvbWNW8S4RlpjYZ9WTqZ totd3KjRnqSbJeREGbYOC2sBY2mF+7w/jqQ9qWUMy4pXve63Qm3cEYY3A2ef3wuTb3 cNWB4FvReUL4Ja7G1fN4jNz7DXLqQqSNiolzED1FrJiUnYvGt1kUu+RQpOreb64yZY bAzRpSUCqTpqg== X-Sender: jared@finder.org Received-SPF: pass client-ip=2600:3c01::f03c:91ff:fe73:2daa; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259220 Archived-At: On 2020-11-15 10:11 am, Eli Zaretskii wrote: >> Date: Sun, 15 Nov 2020 00:49:03 -0800 >> From: Jared Finder via "Emacs development discussions." >> >> >> The first patch is very straightforward and should be trivial to >> review >> and merge. > > Agreed. Great. It's completely independent of the other change, feel free to merge at any time. >> I have a question about the right way to proceed with the second >> patch. >> [...] > > Ouch, this is scary. We have a lot of gray hair from replacing input > functions by seemingly-similar other input functions. And on top of > that, you need changes to read-key. These changes will affect every > "native" mouse subsystem out there, with the benefit being a single > niche mouse subsystem that is an emulator. This sounds like not the > best way, as the risk will be shared by many important configurations > and the benefits by only one not very important one. > > Can you think about a way of doing this that will affect only > xterm-mouse? I'm okay with, for example, replacing read-event in > those cases with some new function that will call a special > xterm-mouse API when xterm-mouse is in effect, and will call > read-event otherwise. Is something like this feasible? I was a little nervous about changing read-key's default behavior too. Happy to explore other options. :) Creating such an alternative function doesn't appear too bad if you're okay with having the same run-with-idle-timer pattern that read-key uses. I do not think it can be xterm specific as it needs to apply all of input-decode-map to be able to return function keys such as [f1] on a native Linux term or an xterm. (This is important for widget-key-sequence-read-event.) However, it can avoid the rest of the complexity of read-key-sequence. I'm imagining something like this (untested code follows, just wanted to give a flavor of it): (defun read-decoded-key () ; I'd love a better name here. ;; Start of code like read-key's code. (let ((keys '()) (timer (run-with-idle-timer read-key-delay t (lambda () (unless (null keys) (throw 'read-key nil)))))) (unwind-protect (while t (push (read-event) keys)) (cancel-timer timer)) ;; Start of new stuff: Apply transformations from input-decode-map. (do-stuff) (vconcat (nreverse keys)))) As you can see, this avoids all the complexity around managing the different keymaps that read-key currently has since it calls read-key-sequence. An alternative is to just use read-key as is in most cases and make my change a parameter / special variable. Most of my patch's changes work fine with the existing behavior of read-key. Only the following changes do not: * lisp/vc/ediff-wind.el (ediff-get-window-by-clicking) ==> As coded, expects the first mouse event returned by read-event to be a down-mouse-X event, which it then follows by another call to read-event to get the mouse-X event. It could be easily changed to only look for the up event. * lisp/strokes.el (strokes-read-stroke, strokes-read-complex-stroke) * lisp/textmodes/artist.el (artist-mode-draw-poly) ==> These both expect to detect a mix of down-mouse-X and mouse-X events. * lisp/wid-edit.el (widget-key-sequence-read-event) ==> This w/o changes to read-key, but with a behavior change. With no changes to read-key it returns just a single up event. Currently on other environments you get both a down and up event (e.g. ). -- MJF