From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc. Date: Fri, 29 Apr 2022 11:10:03 -0700 Organization: UCLA Computer Science Department Message-ID: References: <106f5128-680b-f25e-1316-f7308c49b625@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------XvsjYsPKPsFkvc9kCzJTNk0i" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11245"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: emacs-orgmode , emacs-devel@gnu.org To: Max Nikulin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 20:11:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkV5H-0002jH-A9 for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 20:11:15 +0200 Original-Received: from localhost ([::1]:43640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkV5F-0004mP-VW for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 14:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkV4E-00039v-N9; Fri, 29 Apr 2022 14:10:10 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkV4C-0006ks-Dz; Fri, 29 Apr 2022 14:10:10 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 12F6C16006C; Fri, 29 Apr 2022 11:10:05 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GlTxhOxaPG_T; Fri, 29 Apr 2022 11:10:04 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1DDB116005C; Fri, 29 Apr 2022 11:10:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zgmN7oIFC-ht; Fri, 29 Apr 2022 11:10:04 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E4BE216005E; Fri, 29 Apr 2022 11:10:03 -0700 (PDT) Content-Language: en-US In-Reply-To: <106f5128-680b-f25e-1316-f7308c49b625@gmail.com> Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289016 gmane.emacs.orgmode:144837 Archived-At: This is a multi-part message in MIME format. --------------XvsjYsPKPsFkvc9kCzJTNk0i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/22 07:22, Max Nikulin wrote: > It was still working in most real-life cases. Yes, the current code breaks only in fine-grained cases. Most of the time it'll work fine since people rarely compile the same file twice in the same second. > From my point of view, it is better to rewrite `org-compile-time' to > treat the case when there were no file prior to the call as that the > file has been updated without comparison of timestamps Yes, that sounds simpler and better. How about the attached patch? --------------XvsjYsPKPsFkvc9kCzJTNk0i Content-Type: text/x-patch; charset=UTF-8; name="0001-Improve-org-compile-file-timestamp-handling.patch" Content-Disposition: attachment; filename="0001-Improve-org-compile-file-timestamp-handling.patch" Content-Transfer-Encoding: base64 RnJvbSBmYmQ2NTYxOTUyYWNmMzU5MjM2YWZjZjc5NTdhMTk3Mzc2YTE4YzY2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDI5IEFwciAyMDIyIDExOjA2OjAwIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gSW1wcm92ZSBvcmctY29tcGlsZS1maWxlIHRpbWVzdGFtcCBoYW5kbGluZwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29u dGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKKiBsaXNwL29yZy9vcmctbWFjcy5lbCAo b3JnLWZpbGUtbmV3ZXItdGhhbi1wKToKRG9u4oCZdCBsb3NlIHRpbWVzdGFtcCBpbmZvcm1h dGlvbiBpbiBhbiBhdHRlbXB0IHRvIHdvcmsgYXJvdW5kCnByb2JsZW1zIG9uIGZpbGVzeXN0 ZW1zIHdpdGggY29hcnNlLWdyYWluZWQgdGltZXN0YW1wcy4KKG9yZy1jb21waWxlLWZpbGUp OiBVc2Ugb25seSBmaWxlc3lzdGVtIHRpbWVzdGFtcHM7CmRvbuKAmXQgdHJ5IHRvIGNvbXBh cmUgdGhlbSB0byB0aGUgY3VycmVudCB0aW1lLCBhcwp0aGUgZmlsZXN5c3RlbSBjbG9jayBt YXkgYmUgZGlmZmVyZW50IGZyb20gb3VyIGNsb2NrLgotLS0KIGxpc3Avb3JnL29yZy1tYWNz LmVsIHwgMTQgKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnL29yZy1tYWNzLmVs IGIvbGlzcC9vcmcvb3JnLW1hY3MuZWwKaW5kZXggYmIwNTYyZGRlMC4uOTA3MDQzNTgwYSAx MDA2NDQKLS0tIGEvbGlzcC9vcmcvb3JnLW1hY3MuZWwKKysrIGIvbGlzcC9vcmcvb3JnLW1h Y3MuZWwKQEAgLTI2MCwxNCArMjYwLDggQEAgb3JnLWZpbGUtbmV3ZXItdGhhbi1wCiAgICJO b24tbmlsIGlmIEZJTEUgaXMgbmV3ZXIgdGhhbiBUSU1FLgogRklMRSBpcyBhIGZpbGVuYW1l LCBhcyBhIHN0cmluZywgVElNRSBpcyBhIExpc3AgdGltZSB2YWx1ZSwgYXMKIHJldHVybmVk IGJ5LCBlLmcuLCBgY3VycmVudC10aW1lJy4iCi0gIChhbmQgKGZpbGUtZXhpc3RzLXAgZmls ZSkKLSAgICAgICA7OyBPbmx5IGNvbXBhcmUgdGltZXMgdXAgdG8gd2hvbGUgc2Vjb25kcyBh cyBzb21lIGZpbGUtc3lzdGVtcwotICAgICAgIDs7IChlLmcuIEhGUyspIGRvIG5vdCByZXRh aW4gYW55IGZpbmVyIGdyYW51bGFyaXR5LiAgQXMKLSAgICAgICA7OyBhIGNvbnNlcXVlbmNl LCBtYWtlIHN1cmUgd2UgcmV0dXJuIG5vbi1uaWwgd2hlbiB0aGUgdHdvCi0gICAgICAgOzsg dGltZXMgYXJlIGVxdWFsLgotICAgICAgIChub3QgKHRpbWUtbGVzcy1wIChvcmctdGltZS1j b252ZXJ0LXRvLWludGVnZXIKLQkJCSAgKG50aCA1IChmaWxlLWF0dHJpYnV0ZXMgZmlsZSkp KQotCQkJIChvcmctdGltZS1jb252ZXJ0LXRvLWludGVnZXIgdGltZSkpKSkpCisgICh3aGVu LWxldCAoKG10aW1lIChmaWxlLWF0dHJpYnV0ZS1tb2RpZmljYXRpb24tdGltZSAoZmlsZS1h dHRyaWJ1dGVzIGZpbGUpKSkpCisgICAgKHRpbWUtbGVzcy1wIHRpbWUgbXRpbWUpKSkKIAog KGRlZnVuIG9yZy1jb21waWxlLWZpbGUgKHNvdXJjZSBwcm9jZXNzIGV4dCAmb3B0aW9uYWwg ZXJyLW1zZyBsb2ctYnVmIHNwZWMpCiAgICJDb21waWxlIGEgU09VUkNFIGZpbGUgdXNpbmcg UFJPQ0VTUy4KQEAgLTMwMSw3ICsyOTUsNyBAQCBvcmctY29tcGlsZS1maWxlCiAJIChmdWxs LW5hbWUgKGZpbGUtdHJ1ZW5hbWUgc291cmNlKSkKIAkgKG91dC1kaXIgKG9yIChmaWxlLW5h bWUtZGlyZWN0b3J5IHNvdXJjZSkgIi4vIikpCiAJIChvdXRwdXQgKGV4cGFuZC1maWxlLW5h bWUgKGNvbmNhdCBiYXNlLW5hbWUgIi4iIGV4dCkgb3V0LWRpcikpCi0JICh0aW1lIChjdXJy ZW50LXRpbWUpKQorCSAodGltZSAoZmlsZS1hdHRyaWJ1dGUtbW9kaWZpY2F0aW9uLXRpbWUg KGZpbGUtYXR0cmlidXRlcyBvdXRwdXQpKSkKIAkgKGVyci1tc2cgKGlmIChzdHJpbmdwIGVy ci1tc2cpIChjb25jYXQgIi4gICIgZXJyLW1zZykgIiIpKSkKICAgICAoc2F2ZS13aW5kb3ct ZXhjdXJzaW9uCiAgICAgICAocGNhc2UgcHJvY2VzcwpAQCAtMzIwLDcgKzMxNCw3IEBAIG9y Zy1jb21waWxlLWZpbGUKIAkoXyAoZXJyb3IgIk5vIHZhbGlkIGNvbW1hbmQgdG8gcHJvY2Vz cyAlUyVzIiBzb3VyY2UgZXJyLW1zZykpKSkKICAgICA7OyBDaGVjayBmb3IgcHJvY2VzcyBm YWlsdXJlLiAgT3V0cHV0IGZpbGUgaXMgZXhwZWN0ZWQgdG8gYmUKICAgICA7OyBsb2NhdGVk IGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyBTT1VSQ0UuCi0gICAgKHVubGVzcyAob3JnLWZp bGUtbmV3ZXItdGhhbi1wIG91dHB1dCB0aW1lKQorICAgICh1bmxlc3MgKG9yIChub3QgdGlt ZSkgKG9yZy1maWxlLW5ld2VyLXRoYW4tcCBvdXRwdXQgdGltZSkpCiAgICAgICAoZXJyb3Ig KGZvcm1hdCAiRmlsZSAlUyB3YXNuJ3QgcHJvZHVjZWQlcyIgb3V0cHV0IGVyci1tc2cpKSkK ICAgICBvdXRwdXQpKQogCi0tIAoyLjM0LjEKCg== --------------XvsjYsPKPsFkvc9kCzJTNk0i--