From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Name of buffers created by project-shell Date: Fri, 5 Mar 2021 16:22:14 +0200 Message-ID: References: <87czwh9rv9.fsf@gmail.com> <87wnumj1lx.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38984"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Matthias Meulien , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 05 15:23:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIBMA-000A0n-KA for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Mar 2021 15:23:06 +0100 Original-Received: from localhost ([::1]:52914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIBM9-0000gH-KG for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Mar 2021 09:23:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIBLS-00007x-Tk for emacs-devel@gnu.org; Fri, 05 Mar 2021 09:22:24 -0500 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:33615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIBLQ-0002z8-T0 for emacs-devel@gnu.org; Fri, 05 Mar 2021 09:22:22 -0500 Original-Received: by mail-wr1-x432.google.com with SMTP id 7so2307609wrz.0 for ; Fri, 05 Mar 2021 06:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3uoP6ljTt5OtNaLgMw+maoFPtPe9V70lK/D0xmeEhOE=; b=SIACiNnRPxd1+UkYVmX4f3WMr28Ce75Kf6LU8fXfwrsqduTk36yuizypg0IWRPd4ED K52zOHZVvfmUFd15aZVFw82oOZzhIuJNRX9ZS/t3N+dw4sPDvFZ4aJhb4fChWC7JGqlv k6k+JXc6XjMOx9yo6LbwQr4tyO0kP1isdJKazkB3so+5++fv7ZL0jLClRdzKduvrvN2G LLxAFeW2ammwIXLIgoJwOYho3RxTbTosp+SbdfgHdv1FmEUx+muKuWAp7nmB5TCJtQOc T3/QAEtHBYgVHMHbfGQ5/YixgtXRyLoL3U4SoVCm8C853KBmbG3Fiumd+8rCE4n+uj0D U6XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3uoP6ljTt5OtNaLgMw+maoFPtPe9V70lK/D0xmeEhOE=; b=nJFpi1/SP9F5k2L65mKx1POmk0NyKmJ/ciK/R7N8BE25HGXR5tUV+4M0PaX1HJSEaI RUpjxxJrZDcfhBuV0hO99V8uZEJZ758Er65w8o2O/duXp2e6G7iaCADNdEDr0m9KyqQU YSAeyDDqKvG7ngebf7zPYvH1md2BmWNvEUk3LDzHmUPtqIBHrKSRuWvzUCSHzk0nRoBP JwTYJ6bDRdbfr7VdElgkyjLhErHanx2Zr/1PZghdY1/44qL3CixsJ6YuuB5MhC+pUwHS iKrL9q5Ob8tf7su1D0Nuxb3R0WPBRtLyuug4Nm226PV7gOTGoFOo8ahvj2NdIHWSyyeZ crYQ== X-Gm-Message-State: AOAM531xbnj2Ybjd8ROu4Nrwlp9dRKErHUYAFycS2tvYNH6Zxk1bxIWY /CosWLPO/ljQ4CCm+GM6PaPQ/DjIozI= X-Google-Smtp-Source: ABdhPJwNAQuoMTiPH/uXJ4zsqsR5DOs2sXsa9re8/xdHjv8BdZCtPM8BMXUc8xx0iDwC2sGmuAAT9Q== X-Received: by 2002:a5d:6307:: with SMTP id i7mr9780598wru.305.1614954137779; Fri, 05 Mar 2021 06:22:17 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id s83sm5018783wmf.26.2021.03.05.06.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 06:22:16 -0800 (PST) In-Reply-To: <87wnumj1lx.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=raaahh@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266022 Archived-At: On 04.03.2021 19:50, Juri Linkov wrote: >> There's one problem, though: when called with C-u, the piece of behavior >> which reads as "create a new inferior shell buffer even if one already >> exists" now creates buffers uniquely named according to uniquify's rules, >> which seems to mean >> >> *shell* >> emacs-master/*shell* >> vc/emacs-master/*shell* >> >> instead of what one might expect, like >> >> emacs-master/*shell* >> emacs-master/*shell*<2> >> emacs-master/*shell*<3> > For consistency with C-x p v (project-vc-dir) that creates buffers named > > *vc-dir* > > shouldn't C-x p s (project-shell) create buffers with the same style: > > *shell*<1> > *shell*<2> > *shell*<3> That's what I said, yes. You just have a different uniquify style enabled, so the current behavior looks slightly different. >> Perhaps the solution is not to go through uniquify for this, but then we >> project-shell can't really be consistent with project-vc-dir. > 'project-shell' already constructs buffer names using own style, > so it could switch to another style compatible with > uniquify-buffer-name-style, then construct buffer names > like "*shell*" and allow uniquify to append > a numeric suffix <1>, <2>, <3>. The devil is in the details. To have uniquify do its job properly, I think we have to call create-file-buffer. And apparently we need to fix uniquify--create-file-buffer-advice first.