From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken. Date: Wed, 10 Apr 2019 11:05:02 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20190228202146.GC4686@ACM> <20190228205955.GD4686@ACM> <20190410162203.GA4009@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236235"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: Daniel Colascione , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 10 20:05:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEHba-000zL0-TO for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 20:05:51 +0200 Original-Received: from localhost ([127.0.0.1]:35433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEHbZ-0003UE-Uf for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 14:05:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEHat-0003TM-Dr for emacs-devel@gnu.org; Wed, 10 Apr 2019 14:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEHas-0002VX-DQ for emacs-devel@gnu.org; Wed, 10 Apr 2019 14:05:07 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50010) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEHar-0002UB-UY for emacs-devel@gnu.org; Wed, 10 Apr 2019 14:05:06 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1029F161629; Wed, 10 Apr 2019 11:05:04 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8pJBENfiYlGW; Wed, 10 Apr 2019 11:05:03 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3EE86161620; Wed, 10 Apr 2019 11:05:03 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M1taT1fbv7Hy; Wed, 10 Apr 2019 11:05:03 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 21A7616161D; Wed, 10 Apr 2019 11:05:03 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <20190410162203.GA4009@ACM> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235235 Archived-At: On 4/10/19 9:22 AM, Alan Mackenzie wrote: > All that was needed to disable it was a single line change to set > CHECK_STRUCTS to zero. That would also have sufficed, but the code clutter (and slowdown in the build due to the computation of hashes which forces that part of the build to be sequential) was also annoying. If you really want it we can bring back the mechanism (with CHECK_STRUCTS off by default please!), though I'd rather not - see below. > it was of use to me recently when it reminded me to > amend dump_subr after extending struct subr. I didn't observe that in master - presumably this was in some experimental branch? In master, dump_subr is currently the same as it was when the pdumper was installed. Before making the recent change, I reviewed all the changes made to pdumper.c in master, and observed none where the hashes helped and several where they hurt. Since the portable dumper was added I have made four commits that involved the hashes, and the hashes only got into my way and slowed me down. You made one commit (9c0fa1172fd987a8f23b115145270383a11c12fc) that involved the buffer.h hash, and portions of that commit were mistakenly pushed in pdumper.c's previous commit so the hashes didn't seem to have helped there. The only other persons to make hash-related commits to pdumper.c were Alan and Stefan, and the hashes didn't help there either. As the hashes get in the way of ordinary development (mostly affecting me) and don't seem to help in practice, I really want them to go.