From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master bf7041a: Centralize subprocess creation in a single function. Date: Fri, 25 Dec 2020 19:19:13 -0800 Organization: UCLA Computer Science Department Message-ID: References: <20201224145337.5156.69415@vcs0.savannah.gnu.org> <20201224145339.8699721351@vcs0.savannah.gnu.org> <87r1nfjift.fsf@gnus.org> <87mty3jidw.fsf@gnus.org> <83v9crnpin.fsf@gnu.org> <83tusbnpd1.fsf@gnu.org> <87im8rjh23.fsf@gnus.org> <87eejfjgw5.fsf@gnus.org> <87a6u3jfyp.fsf@gnus.org> <875z4rjfi7.fsf@gnus.org> <83r1nfnms1.fsf@gnu.org> <871rffjekh.fsf@gnus.org> <87wnx7hzge.fsf@gnus.org> <0662240F-DA88-4F47-B348-0EDBD9589E43@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B35F6518D7A4F2C582C7D1B7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 Cc: phst@google.com, Eli Zaretskii , Lars Ingebrigtsen , emacs-devel@gnu.org To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 26 04:19:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt07Y-00018y-4h for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 04:19:56 +0100 Original-Received: from localhost ([::1]:39038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kt07X-0007aD-7g for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 22:19:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt072-0007Aw-50 for emacs-devel@gnu.org; Fri, 25 Dec 2020 22:19:24 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt06y-0002Nz-MN; Fri, 25 Dec 2020 22:19:23 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E633F1600F7; Fri, 25 Dec 2020 19:19:17 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zw_YTPn9m2Z2; Fri, 25 Dec 2020 19:19:14 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 48BA9160110; Fri, 25 Dec 2020 19:19:14 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XcB1_H9ZKBgV; Fri, 25 Dec 2020 19:19:14 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1179D1600F7; Fri, 25 Dec 2020 19:19:14 -0800 (PST) In-Reply-To: <0662240F-DA88-4F47-B348-0EDBD9589E43@acm.org> Content-Language: en-US Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -57 X-Spam_score: -5.8 X-Spam_bar: ----- X-Spam_report: (-5.8 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.561, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261783 Archived-At: This is a multi-part message in MIME format. --------------B35F6518D7A4F2C582C7D1B7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 12/25/20 2:19 AM, Mattias Engdeg=C3=A5rd wrote: > CC malloc/scratch_buffer_grow.o > error: unable to open output file 'malloc/scratch_buffer_grow.o': 'No s= uch file > or directory' > 1 error generated. > make[1]: *** [malloc/scratch_buffer_grow.o] Error 1 > make: *** [lib] Error 2 I installed the attached to try to fix this; please give it a try. --------------B35F6518D7A4F2C582C7D1B7 Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-issues-with-lib-malloc-out-of-dir-builds.patch" Content-Disposition: attachment; filename="0001-Fix-issues-with-lib-malloc-out-of-dir-builds.patch" Content-Transfer-Encoding: quoted-printable >From 597eef7b947a64ae8067058478f26a15c0e24a07 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 25 Dec 2020 19:16:27 -0800 Subject: [PATCH] Fix issues with lib/malloc out-of-dir builds MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported by Mattias Engdeg=C3=A5rd in: https://lists.gnu.org/r/emacs-devel/2020-12/msg01626.html * configure.ac: If the scratch_buffer module is enabled, create lib/malloc and (if doing dependencies) lib/deps/malloc. * lib/Makefile.in (DEPFLAGS) [AUTO_DEPEND]: No longer any need to squash lib dependencies into a single directory. (clean): Also remove */*.o and $(DEPDIR)/*/*.d, to clean out malloc/*.o and deps/malloc/*.d. Just remove *.d files in dependencies so that rm does not complain about not being able to remove deps/malloc. (extraclean): Also remove malloc, if it is empty. --- configure.ac | 6 ++++++ lib/Makefile.in | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 888b415148..bf768441fe 100644 --- a/configure.ac +++ b/configure.ac @@ -5878,6 +5878,12 @@ m4_define AS_MKDIR_P([$dir/deps]) done fi +if $gl_gnulib_enabled_scratch_buffer; then + AS_MKDIR_P([lib/malloc]) + if test $AUTO_DEPEND =3D yes; then + AS_MKDIR_P([lib/deps/malloc]) + fi +fi =20 AC_OUTPUT =20 diff --git a/lib/Makefile.in b/lib/Makefile.in index a280b7a331..e6b1ae6a9a 100644 --- a/lib/Makefile.in +++ b/lib/Makefile.in @@ -67,7 +67,7 @@ SYSTEM_TYPE =3D =20 DEPDIR =3D deps ifeq ($(AUTO_DEPEND),yes) - DEPFLAGS =3D -MMD -MF $(DEPDIR)/$(*F).d -MP + DEPFLAGS =3D -MMD -MF $(DEPDIR)/$*.d -MP -include $(ALLOBJS:%.o=3D$(DEPDIR)/%.d) else DEPFLAGS =3D @@ -118,7 +118,7 @@ TAGS: .PHONY: $(ETAGS) tags =20 clean: - rm -f ./*.[ao] ./*-t \#* $(DEPDIR)/* + rm -f ./*.[ao] ./*/*.o ./*-t \#* $(DEPDIR)/*.d $(DEPDIR)/*/*.d mostlyclean: clean rm -f $(filter-out %-t,$(MOSTLYCLEANFILES)) distclean bootstrap-clean: mostlyclean @@ -127,7 +127,7 @@ distclean bootstrap-clean: maintainer-clean: distclean rm -f TAGS gnulib.mk extraclean: distclean - -rmdir sys 2>/dev/null + -rmdir malloc sys 2>/dev/null =20 .PHONY: mostlyclean clean distclean bootstrap-clean maintainer-clean =20 --=20 2.27.0 --------------B35F6518D7A4F2C582C7D1B7--