* Recent change in gnus-sum.el is bad for XEmacs
[not found] <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org>
@ 2009-01-09 10:38 ` Katsumi Yamaoka
2009-01-09 11:13 ` Katsumi Yamaoka
2009-01-09 17:03 ` Glenn Morris
0 siblings, 2 replies; 4+ messages in thread
From: Katsumi Yamaoka @ 2009-01-09 10:38 UTC (permalink / raw)
To: Glenn Morris; +Cc: ding, emacs-devel
>>>>> In <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org> Glenn Morris wrote:
> CVSROOT: /sources/emacs
> Module name: emacs
> Changes by: Glenn Morris <gm> 09/01/09 04:26:14
> Modified files:
> lisp/gnus : ChangeLog gnus-sum.el
[...]
> +2009-01-09 Glenn Morris <rgm@gnu.org>
> +
> + * gnus-sum.el (gnus-summary-next-article): Replace last-command-char
> + with last-command-event.
> +
[...]
> --- gnus-sum.el 9 Jan 2009 03:01:52 -0000 1.137
> +++ gnus-sum.el 9 Jan 2009 04:26:14 -0000 1.138
> @@ -7625,7 +7625,7 @@
> (t
> (unless (gnus-ephemeral-group-p gnus-newsgroup-name)
> (gnus-summary-jump-to-group gnus-newsgroup-name))
> - (let ((cmd last-command-char)
> + (let ((cmd last-command-event)
> (point
> (with-current-buffer gnus-group-buffer
> (point)))
This change will be merged to the Gnus trunk sooner or later and
then XEmacs will get not to work (I verified). When typing the
SPC key, `last-command-event' will be `10' in Emacs, whereas it
will be the Lisp object `#<keypress-event space>' in XEmacs.
Because of this the form `(equal key cmd)' used in the function
`gnus-summary-walk-group-buffer' will never return t. I have a
solution as follows:
--8<---------------cut here---------------start------------->8---
--- gnus-sum.el~ 2009-01-06 21:59:24 +0000
+++ gnus-sum.el 2009-01-09 10:35:57 +0000
@@ -7696,7 +7696,9 @@
(setq group (gnus-group-group-name))
(switch-to-buffer obuf))
(setq ended nil))
- ((equal key cmd)
+ ((equal key (if (featurep 'xemacs)
+ (event-to-character cmd)
+ cmd))
(if (or (not group)
(gnus-ephemeral-group-p gnus-newsgroup-name))
(gnus-summary-exit)
--8<---------------cut here---------------end--------------->8---
However, I'm not sure it's ok in all cases. Couldn't the change
revert?
Regards,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent change in gnus-sum.el is bad for XEmacs
2009-01-09 10:38 ` Recent change in gnus-sum.el is bad for XEmacs Katsumi Yamaoka
@ 2009-01-09 11:13 ` Katsumi Yamaoka
2009-01-09 17:03 ` Glenn Morris
1 sibling, 0 replies; 4+ messages in thread
From: Katsumi Yamaoka @ 2009-01-09 11:13 UTC (permalink / raw)
To: Glenn Morris; +Cc: ding, emacs-devel
>>>>> Katsumi Yamaoka wrote:
>> +2009-01-09 Glenn Morris <rgm@gnu.org>
>> +
>> + * gnus-sum.el (gnus-summary-next-article): Replace last-command-char
>> + with last-command-event.
> This change will be merged to the Gnus trunk sooner or later and
> then XEmacs will get not to work (I verified). When typing the
> SPC key, `last-command-event' will be `10' in Emacs, whereas it
^^
Oops, it's `32' of course. Sorry.
> will be the Lisp object `#<keypress-event space>' in XEmacs.
[...]
> Couldn't the change revert?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent change in gnus-sum.el is bad for XEmacs
2009-01-09 10:38 ` Recent change in gnus-sum.el is bad for XEmacs Katsumi Yamaoka
2009-01-09 11:13 ` Katsumi Yamaoka
@ 2009-01-09 17:03 ` Glenn Morris
2009-01-10 0:31 ` Katsumi Yamaoka
1 sibling, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2009-01-09 17:03 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: ding, emacs-devel
Katsumi Yamaoka wrote:
> This change will be merged to the Gnus trunk sooner or later and
> then XEmacs will get not to work (I verified).
Sorry, I tried to take account of XEmacs code, but obviously I missed
some places. Please fix as you see fit.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent change in gnus-sum.el is bad for XEmacs
2009-01-09 17:03 ` Glenn Morris
@ 2009-01-10 0:31 ` Katsumi Yamaoka
0 siblings, 0 replies; 4+ messages in thread
From: Katsumi Yamaoka @ 2009-01-10 0:31 UTC (permalink / raw)
To: Glenn Morris; +Cc: ding, emacs-devel
>>>>> In <hqr63cmmyd.fsf@fencepost.gnu.org>
>>>>> Glenn Morris <rgm@gnu.org> wrote:
> Katsumi Yamaoka wrote:
> > This change will be merged to the Gnus trunk sooner or later and
> > then XEmacs will get not to work (I verified).
> Sorry, I tried to take account of XEmacs code, but obviously I missed
> some places. Please fix as you see fit.
I chose reverting. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-10 0:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org>
2009-01-09 10:38 ` Recent change in gnus-sum.el is bad for XEmacs Katsumi Yamaoka
2009-01-09 11:13 ` Katsumi Yamaoka
2009-01-09 17:03 ` Glenn Morris
2009-01-10 0:31 ` Katsumi Yamaoka
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).