find-file annoyance

find-file annoyance

[Katsumi Yamaoka]

Hi,

When I invoke C-x C-f, clear the minibuffer, enter a remote file
name like "/frp.example.com:~/foo", and type C-a or C-b in order
to correct the host name to "ftp.example.com", I cannot move the
point to the place before "~" or ":".  Only <backspace> does it
but I have to retype the whole host name.  In addition, I usually
did `C-x C-f C-a C-k C-g' in order to copy the directory name of
the dired buffer to the kill-ring.  Is there a way to make it
behave like Emacs 22.1?

Thanks in advance.

Re: find-file annoyance

[Miles Bader]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> name like "/frp.example.com:~/foo", and type C-a or C-b in order
> to correct the host name to "ftp.example.com", I cannot move the
> point to the place before "~" or ":".  Only <backspace> does it
> but I have to retype the whole host name.  In addition, I usually
> did `C-x C-f C-a C-k C-g' in order to copy the directory name of
> the dired buffer to the kill-ring.  Is there a way to make it
> behave like Emacs 22.1?

No idea what's actually going on, but this is clearly a bug (not just an
annoyance, though it's certainly an annoying bug :-).

-Miles

-- 
`...the Soviet Union was sliding in to an economic collapse so comprehensive
 that in the end its factories produced not goods but bads: finished products
 less valuable than the raw materials they were made from.'  [The Economist]

Re: find-file annoyance

[Johan Bockgård]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> When I invoke C-x C-f, clear the minibuffer, enter a remote file name
> like "/frp.example.com:~/foo", and type C-a or C-b in order to correct
> the host name to "ftp.example.com", I cannot move the point to the
> place before "~" or ":". Only <backspace> does it but I have to retype
> the whole host name. In addition, I usually did `C-x C-f C-a C-k C-g'
> in order to copy the directory name of the dired buffer to the
> kill-ring. Is there a way to make it behave like Emacs 22.1?

tramp-rfn-eshadow-update-overlay uses narrowing in a way that moves
point (the old point was outside the limits). It needs to save-excursion.
(This patch also replaces a call to `widen' with save-restriction.)


2007-10-17  Johan Bockgård  <bojohan@gnu.org>

	* net/tramp.el (tramp-rfn-eshadow-update-overlay): Save excursion.
	Use `save-restriction' rather than `widen'.


Index: tramp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/tramp.el,v
retrieving revision 1.146
diff -c -r1.146 tramp.el
*** tramp.el	10 Oct 2007 04:55:30 -0000	1.146
--- tramp.el	17 Oct 2007 09:17:42 -0000
***************
*** 2092,2103 ****
  			  (symbol-value 'rfn-eshadow-overlay))
  		 (funcall (symbol-function 'minibuffer-prompt-end)))))
      (when (file-remote-p (buffer-substring-no-properties end (point-max)))
!       (narrow-to-region
!        (1+ (or (string-match "/" (buffer-string) end) end)) (point-max))
!       (let ((rfn-eshadow-overlay tramp-rfn-eshadow-overlay)
! 	    (rfn-eshadow-update-overlay-hook nil))
! 	(funcall (symbol-function 'rfn-eshadow-update-overlay)))
!       (widen))))
  
  (when (boundp 'rfn-eshadow-update-overlay-hook)
    (add-hook 'rfn-eshadow-update-overlay-hook
--- 2092,2104 ----
  			  (symbol-value 'rfn-eshadow-overlay))
  		 (funcall (symbol-function 'minibuffer-prompt-end)))))
      (when (file-remote-p (buffer-substring-no-properties end (point-max)))
!       (save-excursion
! 	(save-restriction
! 	  (narrow-to-region
! 	   (1+ (or (string-match "/" (buffer-string) end) end)) (point-max))
! 	  (let ((rfn-eshadow-overlay tramp-rfn-eshadow-overlay)
! 		(rfn-eshadow-update-overlay-hook nil))
! 	    (funcall (symbol-function 'rfn-eshadow-update-overlay))))))))
  
  (when (boundp 'rfn-eshadow-update-overlay-hook)
    (add-hook 'rfn-eshadow-update-overlay-hook


-- 
Johan Bockgård

Re: find-file annoyance

[Michael Albinus]

bojohan+news@dd.chalmers.se (Johan Bockgård) writes:

Hi Johan,

> tramp-rfn-eshadow-update-overlay uses narrowing in a way that moves
> point (the old point was outside the limits). It needs to save-excursion.
> (This patch also replaces a call to `widen' with save-restriction.)

Your patch looks OK to me. Please install it (or tell me when I shall do).

Best regards, Michael.

Re: find-file annoyance

[Katsumi Yamaoka]

>>>>> Michael Albinus wrote:
> bojohan+news@dd.chalmers.se (Johan Bockgård) writes:

> Hi Johan,

>> tramp-rfn-eshadow-update-overlay uses narrowing in a way that moves
>> point (the old point was outside the limits). It needs to save-excursion.
>> (This patch also replaces a call to `widen' with save-restriction.)

> Your patch looks OK to me. Please install it (or tell me when I shall do).

> Best regards, Michael.

I confirmed the patch solves the problem.  Thanks a lot.

Re: find-file annoyance

[Katsumi Yamaoka]

>>>>>> Michael Albinus wrote:

>> Your patch looks OK to me. Please install it (or tell me when I shall do).

>>>>> Katsumi Yamaoka wrote:

> I confirmed the patch solves the problem.  Thanks a lot.

I've installed Johan Bockgård's patch in the trunk.  Thanks.