23.0.50; [message-send-mail-function] wrong description and regression

23.0.50; [message-send-mail-function] wrong description and regression

[Luca Capello]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hello!

Please Cc: me, I'm not subscribed to the list.

Since at least one week `message-send-mail-function' gets assigned a
wrong default value, which, according to its description, should be
`message-send-mail-with-sendmail'.  However, it seems that the default
value is `smtpmail-send-it'.  In fact, I discovered this bug because
after the weekly upgrade of the Debian emacs-snapshot package I couldn't
send mail anymore from Gnus.

Steps to reproduce the bug:

  $ emacs -Q
  M-: (require 'message)
  C-h v message-send-mail-function

The bug is caused by the fact that `sendmail-program' isn't bounded in
lisp/gnus/message.el:624.  The following steps restore the "default"
behavior:

  $ emacs -Q
  M-: (require 'sendmail)
  M-: (require 'message)
  C-h v message-send-mail-function

Thx, bye,
Gismo / Luca

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.0.50/etc/DEBUG for instructions.


In GNU Emacs 23.0.50.1 (x86_64-pc-linux-gnu)
 of 2007-11-19 on elegiac, modified by Debian
 (Debian emacs-snapshot package, version 1:20071119-1)
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.50/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.0.50/leim' '--with-x=no' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  gpm-mouse-mode: t
  display-battery-mode: t
  display-time-mode: t
  show-paren-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
A ESC [ B ESC [ B ESC [ B ESC [ A ESC [ A ESC [ A ESC 
[ A ESC [ A ESC [ A ESC [ A ESC [ A ESC [ B ESC [ B 
ESC [ B ESC [ B ESC [ B ESC [ A ESC [ A ESC [ A ESC 
[ A ESC [ B C-c ESC f g ESC [ A ESC [ A ESC [ A ESC 
[ A ESC [ A ESC [ A ESC [ A ESC [ A ESC [ A g ESC [ 
B ESC [ A ESC [ A ESC [ A RET RET # RET # ESC [ B RET 
# ESC [ B ESC [ B ESC [ B RET # RET # RET # RET # ESC 
[ B RET # ESC > ESC < B DEL y x RET ESC u ESC [ A B 
m C-a C-k n n m l TAB l i TAB D e b i TAB p r TAB RET 
ESC [ B # # # ESC [ A ESC [ A B m C-a C-k n n m l TAB 
l i TAB D e DEL DEL B l u TAB RET ESC [ B ESC [ B ESC 
[ B RET y B m C-a C-k n n m l TAB l i TAB D e b i TAB 
N e TAB RET x q ESC x d e b i TAB DEL DEL DEL DEL DEL 
DEL DEL e m a c s TAB p r e TAB DEL DEL DEL r e p o 
TAB TAB DEL DEL DEL DEL DEL DEL DEL DEL DEL DEL r e 
p o TAB r t TAB e m TAB b u TAB RET

Recent messages:
Wrote /home/luca/Mail/lists/BlueZ-devel/9114
Wrote /home/luca/Mail/lists/BlueZ-devel/9115
Key 0x88D224B6 not found; attempt to fetch? (y or n) 
Contacting host: subkeys.pgp.net:11371
Moving to nnml:lists.Debian.NewMaint: (160088)...
Wrote /home/luca/Mail/lists/Debian/NewMaint/652
Generating summary...done
Exiting summary buffer and applying spam rules
nnimap: Setting marks in INBOX...done
Making completion list...

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Dan Nicolaescu]

Luca Capello <luca@pca.it> writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > Hello!
  > 
  > Please Cc: me, I'm not subscribed to the list.
  > 
  > Since at least one week `message-send-mail-function' gets assigned a
  > wrong default value, which, according to its description, should be
  > `message-send-mail-with-sendmail'.  However, it seems that the default
  > value is `smtpmail-send-it'.  In fact, I discovered this bug because
  > after the weekly upgrade of the Debian emacs-snapshot package I couldn't
  > send mail anymore from Gnus.
  > 
  > Steps to reproduce the bug:
  > 
  >   $ emacs -Q
  >   M-: (require 'message)
  >   C-h v message-send-mail-function
  > 
  > The bug is caused by the fact that `sendmail-program' isn't bounded in
  > lisp/gnus/message.el:624.  The following steps restore the "default"
  > behavior:

Thanks for the bug report.
This has been known for a few weeks, Reiner Steib has a fix for it, he
said he'd install it when he gets a chance.

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Reiner Steib]

On Tue, Nov 20 2007, Dan Nicolaescu wrote:

> This has been known for a few weeks, Reiner Steib has a fix for it, he
> said he'd install it when he gets a chance.

Done.  Please try.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Andreas Schwab]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Tue, Nov 20 2007, Dan Nicolaescu wrote:
>
>> This has been known for a few weeks, Reiner Steib has a fix for it, he
>> said he'd install it when he gets a chance.
>
> Done.  Please try.

Symbol's value as variable is void: program

(defun message-send-mail-function ()
  "Return suitable value for the variable `message-send-mail-function'."
  (cond ((and sendmail-program
        (executable-find program))
                         ^^^^^^^
Should be sendmail-program?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Dan Nicolaescu]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

  > On Tue, Nov 20 2007, Dan Nicolaescu wrote:
  > 
  > > This has been known for a few weeks, Reiner Steib has a fix for it, he
  > > said he'd install it when he gets a chance.
  > 
  > Done.  Please try.

When starting gnus I get an error about an unknown variable
sendmail-program. It works fine if gnus is started after 
M-x load-library RET sendmail RET.

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Andreas Schwab]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Tue, Nov 20 2007, Dan Nicolaescu wrote:
>
>> This has been known for a few weeks, Reiner Steib has a fix for it, he
>> said he'd install it when he gets a chance.
>
> Done.  Please try.

More problems:

In toplevel form:
../../emacs/lisp/mh-e/mh-show.el:43:1:Error: Symbol's value as variable is void: sendmail-program

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Katsumi Yamaoka]

>>>>> Andreas Schwab wrote:

> (defun message-send-mail-function ()
>   "Return suitable value for the variable `message-send-mail-function'."
>   (cond ((and sendmail-program
>         (executable-find program))
>                          ^^^^^^^
> Should be sendmail-program?

This doesn't fix it.  While `make bootstrap' I got:

Compiling /Work/emacs/lisp/./mh-e/mh-show.el
In toplevel form:
mh-e/mh-show.el:43:1:Error: Symbol's value as variable is void: sendmail-program

Maybe it should be:

(defun message-send-mail-function ()
  "Return suitable value for the variable `message-send-mail-function'."
  (cond ((and (boundp 'sendmail-program) sendmail-program)
	      (executable-find sendmail-program))

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Luca Capello]

Hi all!

On Wed, 21 Nov 2007 01:11:50 +0100, Katsumi Yamaoka wrote:
>>>>>> Andreas Schwab wrote:
>> (defun message-send-mail-function ()
>>   "Return suitable value for the variable `message-send-mail-function'."
>>   (cond ((and sendmail-program
>>         (executable-find program))
>>                          ^^^^^^^
>> Should be sendmail-program?
>
> This doesn't fix it.  While `make bootstrap' I got:
>
> Compiling /Work/emacs/lisp/./mh-e/mh-show.el
> In toplevel form:
> mh-e/mh-show.el:43:1:Error: Symbol's value as variable is void: sendmail-program
>
> Maybe it should be:
>
> (defun message-send-mail-function ()
>   "Return suitable value for the variable `message-send-mail-function'."
>   (cond ((and (boundp 'sendmail-program) sendmail-program)
> 	      (executable-find sendmail-program))

For me the *obvious* fix is the following:

--8<---------------cut here---------------start------------->8---
Index: lisp/gnus/message.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/message.el,v
retrieving revision 1.127
diff -u -r1.127 message.el
--- lisp/gnus/message.el	9 Nov 2007 09:46:00 -0000	1.127
+++ lisp/gnus/message.el	21 Nov 2007 00:29:49 -0000
@@ -50,7 +50,7 @@
 (require 'mml)
 (require 'rfc822)
 (require 'ecomplete)
-
+(require 'sendmail)
 
 (defgroup message '((user-mail-address custom-variable)
 		    (user-full-name custom-variable))
--8<---------------cut here---------------end--------------->8---

Loading the local and modified lisp/gnus/message.el instead of
(require 'message) on an `emacs -Q` clearly sets
`message-send-mail-function' to the documentation default value
`message-send-mail-with-sendmail'.

Thx, bye,
Gismo / Luca

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:

> Maybe it should be:

> (defun message-send-mail-function ()
>   "Return suitable value for the variable `message-send-mail-function'."
>   (cond ((and (boundp 'sendmail-program) sendmail-program)
                                                           ^
                              Please strip this parenthesis.

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Katsumi Yamaoka]

>>>>> Luca Capello wrote:

> For me the *obvious* fix is the following:

> --- lisp/gnus/message.el	9 Nov 2007 09:46:00 -0000	1.127
> +++ lisp/gnus/message.el	21 Nov 2007 00:29:49 -0000
[...]
> +(require 'sendmail)

If it will be done, we have one more work. ;-)

*** message.el~	Tue Nov 20 21:52:32 2007
--- message.el	Wed Nov 21 01:00:47 2007
***************
*** 4427,4441 ****
  		       'call-process-region
  		       (append
  			(list (point-min) (point-max)
! 			      (cond ((boundp 'sendmail-program)
! 				     sendmail-program)
! 				    ((file-exists-p "/usr/sbin/sendmail")
! 				     "/usr/sbin/sendmail")
! 				    ((file-exists-p "/usr/lib/sendmail")
! 				     "/usr/lib/sendmail")
! 				    ((file-exists-p "/usr/ucblib/sendmail")
! 				     "/usr/ucblib/sendmail")
! 				    (t "fakemail"))
  			      nil errbuf nil "-oi")
  			message-sendmail-extra-arguments
  			;; Always specify who from,
--- 4427,4433 ----
  		       'call-process-region
  		       (append
  			(list (point-min) (point-max)
! 			      sendmail-program
  			      nil errbuf nil "-oi")
  			message-sendmail-extra-arguments
  			;; Always specify who from,

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Reiner Steib]

On Wed, Nov 21 2007, Katsumi Yamaoka wrote:

>>>>>> Andreas Schwab wrote:
>
>> (defun message-send-mail-function ()
>>   "Return suitable value for the variable `message-send-mail-function'."
>>   (cond ((and sendmail-program
>>         (executable-find program))
>>                          ^^^^^^^
>> Should be sendmail-program?
>
> This doesn't fix it.  While `make bootstrap' I got:

I have committed another fix.  I can't test bootstrap because it fails
for me:

Generating autoloads for emacs-lisp/checkdoc.el...
Generating autoloads for emacs-lisp/checkdoc.el...done
Symbol's function definition is void: declare-function
make[3]: *** [autoloads] Error 255
make[3]: Leaving directory `[...]/cvs-HEAD/i686/lisp'
make[2]: *** [bootstrap-prepare] Error 2
make[2]: Leaving directory `[...]/cvs-HEAD/i686/lisp'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `[...]/cvs-HEAD/i686'
make: *** [bootstrap] Error 2

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: 23.0.50; [message-send-mail-function] wrong description and regression

[Katsumi Yamaoka]

>>>>> Reiner Steib wrote:

> I have committed another fix.

Thanks.

> I can't test bootstrap because it fails for me:

It seems to have fixed by now.