* Re: master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications
@ 2015-11-16 1:26 Katsumi Yamaoka
2015-11-16 3:57 ` Katsumi Yamaoka
2015-11-17 0:16 ` John Wiegley
0 siblings, 2 replies; 3+ messages in thread
From: Katsumi Yamaoka @ 2015-11-16 1:26 UTC (permalink / raw)
To: emacs-devel
On Sun Nov 15 14:04:30 2015 -0500, Stefan Monnier wrote:
> * lisp/progmodes/verilog-mode.el: Use with-silent-modifications
> (verilog-save-buffer-state): Use with-silent-modifications when available.
When bootstrapping Emacs 25.1.50 I got:
In toplevel form:
progmodes/verilog-mode.el:3335:1:Error: Symbol's function definition is void: \,@
Makefile:268: recipe for target 'progmodes/verilog-mode.elc' failed
Maybe the backquotes nesting in verilog-save-buffer-state is
unreasonable. I used the following makeshift to pass the build:
--- verilog-mode.el~ 2015-11-15 21:55:40.234433900 +0000
+++ verilog-mode.el 2015-11-16 00:55:57.518294500 +0000
@@ -3239,3 +3239,4 @@
,(if (fboundp 'with-silent-modifications)
- (with-silent-modifications ,@body)
+ (eval (cons 'with-silent-modifications
+ (mapcar (lambda (x) (list 'quote x)) body)))
;; From c-save-buffer-state
Regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications
2015-11-16 1:26 master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications Katsumi Yamaoka
@ 2015-11-16 3:57 ` Katsumi Yamaoka
2015-11-17 0:16 ` John Wiegley
1 sibling, 0 replies; 3+ messages in thread
From: Katsumi Yamaoka @ 2015-11-16 3:57 UTC (permalink / raw)
To: emacs-devel
On Mon, 16 Nov 2015 10:26:03 +0900, Katsumi Yamaoka wrote:
> In toplevel form:
> progmodes/verilog-mode.el:3335:1:Error: Symbol's function definition is void: \,@
> Makefile:268: recipe for target 'progmodes/verilog-mode.elc' failed
Confirmed this has been fixed. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications
2015-11-16 1:26 master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications Katsumi Yamaoka
2015-11-16 3:57 ` Katsumi Yamaoka
@ 2015-11-17 0:16 ` John Wiegley
1 sibling, 0 replies; 3+ messages in thread
From: John Wiegley @ 2015-11-17 0:16 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: emacs-devel
>>>>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Maybe the backquotes nesting in verilog-save-buffer-state is
> unreasonable. I used the following makeshift to pass the build:
> --- verilog-mode.el~ 2015-11-15 21:55:40.234433900 +0000
> +++ verilog-mode.el 2015-11-16 00:55:57.518294500 +0000
> @@ -3239,3 +3239,4 @@
> ,(if (fboundp 'with-silent-modifications)
> - (with-silent-modifications ,@body)
> + (eval (cons 'with-silent-modifications
> + (mapcar (lambda (x) (list 'quote x)) body)))
> ;; From c-save-buffer-state
The ,@body interpolation didn't work because it wasn't in a backqouted form.
The equivalent should have been: (apply #'with-silent-modifications body) to
execute it immediately, or `(with-silent-modifications ,@body), which should
be equivalent to what you wrote.
John
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-17 0:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 1:26 master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications Katsumi Yamaoka
2015-11-16 3:57 ` Katsumi Yamaoka
2015-11-17 0:16 ` John Wiegley
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).