* Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data):
[not found] ` <E1ZoUwg-0000RB-JB@vcs.savannah.gnu.org>
@ 2015-10-20 14:15 ` Stefan Monnier
2015-10-21 0:32 ` Katsumi Yamaoka
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-10-20 14:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Katsumi Yamaoka, Michael Sperber
> ("pdf"
> (viewer . doc-view-mode)
> (type . "application/pdf")
> - (test . (eq window-system 'x)))
> + (test . (and (fboundp 'doc-view-mode)
> + (eq window-system 'x))))
Should this be redundant? I mean shouldn't the generic code check
fboundp of the `viewer' anyway?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data):
2015-10-20 14:15 ` [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data): Stefan Monnier
@ 2015-10-21 0:32 ` Katsumi Yamaoka
2015-10-21 16:11 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Katsumi Yamaoka @ 2015-10-21 0:32 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Michael Sperber, emacs-devel
On Tue, 20 Oct 2015 10:15:09 -0400, Stefan Monnier wrote:
>> ("pdf"
>> (viewer . doc-view-mode)
>> (type . "application/pdf")
>> - (test . (eq window-system 'x)))
>> + (test . (and (fboundp 'doc-view-mode)
>> + (eq window-system 'x))))
> Should this be redundant? I mean shouldn't the generic code check
> fboundp of the `viewer' anyway?
Well, do you mean we should not add non-existent viewer to
mailcap-mime-data in like this way?
(defvar mailcap-mime-data
`(("application"
[...]
,@(when (fboundp 'doc-view-mode)
'(("pdf"
(viewer . doc-view-mode)
(type . "application/pdf")
(test . (eq window-system 'x)))))
[...]
It would be perhaps better than adding the fboundp check to
the test token.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data):
2015-10-21 0:32 ` Katsumi Yamaoka
@ 2015-10-21 16:11 ` Stefan Monnier
2015-10-21 22:22 ` Katsumi Yamaoka
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-10-21 16:11 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: Michael Sperber, emacs-devel
>> Should this be redundant? I mean shouldn't the generic code check
>> fboundp of the `viewer' anyway?
> Well, do you mean we should not add non-existent viewer to
> mailcap-mime-data in like this way?
No, I mean that which ever code runs the `test' field should also check
that the `viewer' actually exists.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data):
2015-10-21 16:11 ` Stefan Monnier
@ 2015-10-21 22:22 ` Katsumi Yamaoka
2015-10-22 0:10 ` Katsumi Yamaoka
0 siblings, 1 reply; 5+ messages in thread
From: Katsumi Yamaoka @ 2015-10-21 22:22 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Michael Sperber, emacs-devel
On Wed, 21 Oct 2015 12:11:12 -0400, Stefan Monnier wrote:
>>> Should this be redundant? I mean shouldn't the generic code check
>>> fboundp of the `viewer' anyway?
>> Well, do you mean we should not add non-existent viewer to
>> mailcap-mime-data in like this way?
> No, I mean that which ever code runs the `test' field should also check
> that the `viewer' actually exists.
I see. I'll remove the fboundp checks from `mailcap-mime-data'
and make `mailcap-mailcap-entry-passes-test' do it. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data):
2015-10-21 22:22 ` Katsumi Yamaoka
@ 2015-10-22 0:10 ` Katsumi Yamaoka
0 siblings, 0 replies; 5+ messages in thread
From: Katsumi Yamaoka @ 2015-10-22 0:10 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Michael Sperber, emacs-devel
On Thu, 22 Oct 2015 07:22:43 +0900, Katsumi Yamaoka wrote:
> I see. I'll remove the fboundp checks from `mailcap-mime-data'
> and make `mailcap-mailcap-entry-passes-test' do it. Thanks.
Done.
But mailcap-viewer-passes-test, not mailcap-mailcap-entry-passes-test.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-22 0:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151020111910.1636.10529@vcs.savannah.gnu.org>
[not found] ` <E1ZoUwg-0000RB-JB@vcs.savannah.gnu.org>
2015-10-20 14:15 ` [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data): Stefan Monnier
2015-10-21 0:32 ` Katsumi Yamaoka
2015-10-21 16:11 ` Stefan Monnier
2015-10-21 22:22 ` Katsumi Yamaoka
2015-10-22 0:10 ` Katsumi Yamaoka
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).