From: Katsumi Yamaoka <yamaoka@jpl.org>
To: emacs-devel@gnu.org
Cc: emacs-pretest-bug@gnu.org
Subject: Re: bootstrap fails in byte-op.el
Date: Fri, 24 Aug 2007 09:02:50 +0900 [thread overview]
Message-ID: <b4md4xdpzo5.fsf@jpl.org> (raw)
In-Reply-To: j4veb5vp4w.fsf@fencepost.gnu.org
>>>>> Glenn Morris wrote:
> Bootstrapping current trunk fails compiling byte-opt.el:
> In toplevel form:
> emacs-lisp/byte-opt.el:288:51:Error: Wrong type argument: listp, restp
> make[2]: *** [compile] Error 1
It happens when the <test> element of a `(if <test>...)' form is
not a list. How about this?
*** byte-opt.el~ Thu Aug 23 22:01:17 2007
--- byte-opt.el Thu Aug 23 23:52:04 2007
***************
*** 1020,1026 ****
;; (if <test> nil <else...>) ==> (if (not <test>) (progn <else...>))
;; (if <test> <then> nil) ==> (if <test> <then>)
(let ((clause (nth 1 form)))
! (cond ((eq (car clause) 'progn)
(if (null (cddr clause))
;; A trivial `progn'.
(byte-optimize-if `(if ,(cadr clause) ,@(nthcdr 2 form)))
--- 1020,1026 ----
;; (if <test> nil <else...>) ==> (if (not <test>) (progn <else...>))
;; (if <test> <then> nil) ==> (if <test> <then>)
(let ((clause (nth 1 form)))
! (cond ((eq (car-safe clause) 'progn)
(if (null (cddr clause))
;; A trivial `progn'.
(byte-optimize-if `(if ,(cadr clause) ,@(nthcdr 2 form)))
next prev parent reply other threads:[~2007-08-24 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 22:53 bootstrap fails in byte-op.el Glenn Morris
2007-08-24 0:02 ` Katsumi Yamaoka [this message]
2007-08-24 1:21 ` Glenn Morris
2007-08-24 14:39 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4md4xdpzo5.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).