unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master e7b9a6f: * lisp/mail/rfc2047.el: Use cl-lib & lexical-binding, silence warning
       [not found] ` <20170522031906.C381521035@vcs0.savannah.gnu.org>
@ 2017-05-22  4:02   ` Katsumi Yamaoka
  2017-05-22 20:53     ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Katsumi Yamaoka @ 2017-05-22  4:02 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

On Sun, 21 May 2017 23:19:06 -0400, Stefan Monnier wrote:
> branch: master
> commit e7b9a6fc4adc584b1c89a8e7502734d063fab2cd
>     * lisp/mail/rfc2047.el: Use cl-lib & lexical-binding, silence warning
>     (rfc2047-decode-encoded-words): Use dolist.

Now a form like the following causes an error:

(rfc2047-decode-string "=?utf-8?Q?=E3=81=82?=")

Debugger entered--Lisp error: (wrong-type-argument characterp ("utf-8" 81 "=E3=81=82" "=?utf-8?Q?=E3=81=82?="))
  concat("あ" (("utf-8" 81 "=E3=81=82" "=?utf-8?Q?=E3=81=82?=")))
  (setq words (concat
               (or (and (setq cs (car (car rest)))
                        (condition-case code
                            (decode-coding-string (cdr (car rest)) cs)
                          (error
                           (message "%s" (error-message-string code))
                           nil)))
                   (concat (if (cdr rest) (progn " "))
                           (cdr (car rest))
                           (if (and words
                                    (not (eq ... 32)))
                               (progn " "))))
               words)
        rest (cdr rest))

Formerly `words' was initialized to nil implicitly by (pop words).



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master e7b9a6f: * lisp/mail/rfc2047.el: Use cl-lib & lexical-binding, silence warning
  2017-05-22  4:02   ` master e7b9a6f: * lisp/mail/rfc2047.el: Use cl-lib & lexical-binding, silence warning Katsumi Yamaoka
@ 2017-05-22 20:53     ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2017-05-22 20:53 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: emacs-devel

> Formerly `words' was initialized to nil implicitly by (pop words).

Duh, indeed,


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-22 20:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170522031905.14416.71136@vcs0.savannah.gnu.org>
     [not found] ` <20170522031906.C381521035@vcs0.savannah.gnu.org>
2017-05-22  4:02   ` master e7b9a6f: * lisp/mail/rfc2047.el: Use cl-lib & lexical-binding, silence warning Katsumi Yamaoka
2017-05-22 20:53     ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).