From: Katsumi Yamaoka <yamaoka@jpl.org>
To: emacs-devel@gnu.org
Subject: Re: master 11abc4a: Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk
Date: Tue, 02 Feb 2021 09:44:57 +0900 [thread overview]
Message-ID: <b4m5z3bb8mu.fsf@jpl.org> (raw)
In-Reply-To: 20210131223954.A429420DF3@vcs0.savannah.gnu.org
On Sun, 31 Jan 2021 17:39:54 -0500, Stefan Monnier wrote:
> branch: master
> commit 11abc4aef42ceaea451c264e5a7292e765d4f31b
> Merge: cb72b83 d2341eb
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk
It's not a bug but my custom face setting got to malfunction by
this change, i.e., to turn lexical-binding on on the gnus files.
My custom face setting is something like the following:
(push '((string-match "REGEX" group) . custom-face)
gnus-group-highlight)
Where `group' is a group name; it aimed to highlight groups of
which the name match "REGEX" by `custom-face' in the Group buffer.
However, `group' is no longer a bound variable now. So, I'd like
to add `group' to an env list in `gnus-group-update-eval-form' as
the patch below. Is it ok? Thanks.
--- gnus-group.el~ 2021-02-01 22:35:19.611070900 +0000
+++ gnus-group.el 2021-02-02 00:41:32.041329700 +0000
@@ -1639,5 +1639,6 @@
(cons 'score (or (gnus-info-score info) 0))
(cons 'ticked (gnus-range-length (cdr (assq 'tick marked))))
- (cons 'group-age (gnus-group-timestamp-delta group)))))
+ (cons 'group-age (gnus-group-timestamp-delta group))
+ (cons 'group group))))
(while (and list
(not (eval (caar list) env)))
next parent reply other threads:[~2021-02-02 0:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131223952.429.10439@vcs0.savannah.gnu.org>
[not found] ` <20210131223954.A429420DF3@vcs0.savannah.gnu.org>
2021-02-02 0:44 ` Katsumi Yamaoka [this message]
2021-02-02 2:58 ` master 11abc4a: Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk Stefan Monnier
2021-02-02 5:41 ` Richard Stallman
2021-02-02 6:38 ` Tassilo Horn
2021-02-02 9:06 ` tomas
2021-02-02 15:23 ` Eli Zaretskii
2021-02-02 16:01 ` tomas
2021-02-02 16:21 ` Eli Zaretskii
2021-02-02 16:34 ` git things [was: master 11abc4a: Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk] tomas
2021-02-03 5:51 ` master 11abc4a: Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk Richard Stallman
2021-02-02 8:16 ` Andreas Schwab
2021-02-02 15:06 ` Eli Zaretskii
2021-02-03 5:52 ` Richard Stallman
2021-02-03 14:32 ` Eli Zaretskii
2021-02-04 5:47 ` Richard Stallman
2021-02-02 9:05 ` Lars Ingebrigtsen
2021-02-02 14:43 ` Stefan Monnier
2021-02-02 14:53 ` Lars Ingebrigtsen
2021-02-02 22:12 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4m5z3bb8mu.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).