Re: master 97934ff: Attach text files correctly in Message

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Re: master 97934ff: Attach text files correctly in Message
       [not found] ` <20170125162832.648B4220158@vcs.savannah.gnu.org>
@ 2017-01-27  2:48   ` Katsumi Yamaoka
  2017-01-27  7:57     ` Eli Zaretskii
                       ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Katsumi Yamaoka @ 2017-01-27  2:48 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

Hi Lars,

On Wed, 25 Jan 2017 16:28:32 +0000, Lars Ingebrigtsen wrote:
> branch: master
> commit 97934ffb5673fe7d7498fb31a9bdf32fd8e0c5c7
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>

>     Attach text files correctly in Message
[...]
> --- a/lisp/gnus/mml.el
> +++ b/lisp/gnus/mml.el
[...]
> -	  (mm-with-multibyte-buffer
> +	  (with-temp-buffer
> +	    (set-buffer-multibyte nil)

This breaks a message containing non-ASCII text to send; the
contents are inserted into that unibyte buffer.  See the article
<b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
Could you please fix it?

Thanks.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
@ 2017-01-27  7:57     ` Eli Zaretskii
  2017-01-27 11:32       ` Lars Ingebrigtsen
  2017-01-27 11:33     ` Lars Ingebrigtsen
                       ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2017-01-27  7:57 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: larsi, emacs-devel

> Date: Fri, 27 Jan 2017 11:48:30 +0900
> From: Katsumi Yamaoka <yamaoka@jpl.org>
> Cc: emacs-devel@gnu.org
> 
> > --- a/lisp/gnus/mml.el
> > +++ b/lisp/gnus/mml.el
> [...]
> > -	  (mm-with-multibyte-buffer
> > +	  (with-temp-buffer
> > +	    (set-buffer-multibyte nil)
> 
> This breaks a message containing non-ASCII text to send; the
> contents are inserted into that unibyte buffer.  See the article
> <b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
> Could you please fix it?

When I read those changes, I actually wondered why it was necessary to
set the buffer unibyte.  It shouldn't be needed with the current Emacs
codebase, inserting unibyte text into a multibyte buffer and then
decoding it should "just work".



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27  7:57     ` Eli Zaretskii
@ 2017-01-27 11:32       ` Lars Ingebrigtsen
  0 siblings, 0 replies; 10+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-27 11:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Katsumi Yamaoka, emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> When I read those changes, I actually wondered why it was necessary to
> set the buffer unibyte.  It shouldn't be needed with the current Emacs
> codebase, inserting unibyte text into a multibyte buffer and then
> decoding it should "just work".

We want neither encoding nor decoding of octets from files in that part
of the code, so unibyte buffers are the right thing to do in the "file"
part of that code.  Text from other buffers should be handled otherwise,
though... 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
  2017-01-27  7:57     ` Eli Zaretskii
@ 2017-01-27 11:33     ` Lars Ingebrigtsen
  2017-01-27 13:14       ` Katsumi Yamaoka
  2017-01-27 12:42     ` Lars Ingebrigtsen
                       ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-27 11:33 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: emacs-devel

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> This breaks a message containing non-ASCII text to send; the
> contents are inserted into that unibyte buffer.  See the article
> <b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
> Could you please fix it?

I'm unable to reproduce the bug -- I can send messages with non-ASCII
text just fine.

Do you have a recipe for how to reproduce it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27 11:33     ` Lars Ingebrigtsen
@ 2017-01-27 13:14       ` Katsumi Yamaoka
  2017-01-27 13:18         ` Katsumi Yamaoka
  0 siblings, 1 reply; 10+ messages in thread
From: Katsumi Yamaoka @ 2017-01-27 13:14 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

> > This breaks a message containing non-ASCII text to send; the
> > contents are inserted into that unibyte buffer.  See the article
> > <b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
> > Could you please fix it?

> I'm unable to reproduce the bug -- I can send messages with non-ASCII
> text just fine.

> Do you have a recipe for how to reproduce it?

Hmm, I do the same as usual.  Write a message:

From: foo
To: bar
Subject: B
--text follows this line--
B

And type `C-c C-c'.  The problem is reproducible by `C-c RET P'
as well.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27 13:14       ` Katsumi Yamaoka
@ 2017-01-27 13:18         ` Katsumi Yamaoka
  0 siblings, 0 replies; 10+ messages in thread
From: Katsumi Yamaoka @ 2017-01-27 13:18 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> Hmm, I do the same as usual.  Write a message:

> From: foo
> To: bar
> Subject: B
> --text follows this line--
> B

> And type `C-c C-c'.  The problem is reproducible by `C-c RET P'
> as well.

Oops!  I meant:

From: foo
To: bar
Subject: あ
--text follows this line--
あ



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
  2017-01-27  7:57     ` Eli Zaretskii
  2017-01-27 11:33     ` Lars Ingebrigtsen
@ 2017-01-27 12:42     ` Lars Ingebrigtsen
  2017-01-27 12:54     ` Lars Ingebrigtsen
  2017-01-29 16:10     ` Lars Ingebrigtsen
  4 siblings, 0 replies; 10+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-27 12:42 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: emacs-devel

Sorry; I'm able to reproduce the bug now.  8859-1 characters seems to
survive the wrong transformations here, but not other characters.

I'll fix it...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
                       ` (2 preceding siblings ...)
  2017-01-27 12:42     ` Lars Ingebrigtsen
@ 2017-01-27 12:54     ` Lars Ingebrigtsen
  2017-01-29 16:10     ` Lars Ingebrigtsen
  4 siblings, 0 replies; 10+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-27 12:54 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: emacs-devel

・ OK, pushed a patch that seems to fix the issue.
・ This is the test.
・ Did it work?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
                       ` (3 preceding siblings ...)
  2017-01-27 12:54     ` Lars Ingebrigtsen
@ 2017-01-29 16:10     ` Lars Ingebrigtsen
  2017-01-29 23:33       ` Katsumi Yamaoka
  4 siblings, 1 reply; 10+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-29 16:10 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: emacs-devel

Did the further changes I made in this area fix the problem you were
seeing?  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: master 97934ff: Attach text files correctly in Message
  2017-01-29 16:10     ` Lars Ingebrigtsen
@ 2017-01-29 23:33       ` Katsumi Yamaoka
  0 siblings, 0 replies; 10+ messages in thread
From: Katsumi Yamaoka @ 2017-01-29 23:33 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

On Sun, 29 Jan 2017 17:10:04 +0100, Lars Ingebrigtsen wrote:
> Did the further changes I made in this area fix the problem you were
> seeing?

At least sending Ｊａｐａｎｅｓｅ mails is OK.  Thanks for fixing.
I'm going to look into the new code for every feature.

Regards,



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-01-29 23:33 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170125162832.21457.64236@vcs.savannah.gnu.org>
     [not found] ` <20170125162832.648B4220158@vcs.savannah.gnu.org>
2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
2017-01-27  7:57     ` Eli Zaretskii
2017-01-27 11:32       ` Lars Ingebrigtsen
2017-01-27 11:33     ` Lars Ingebrigtsen
2017-01-27 13:14       ` Katsumi Yamaoka
2017-01-27 13:18         ` Katsumi Yamaoka
2017-01-27 12:42     ` Lars Ingebrigtsen
2017-01-27 12:54     ` Lars Ingebrigtsen
2017-01-29 16:10     ` Lars Ingebrigtsen
2017-01-29 23:33       ` Katsumi Yamaoka

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).