From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Which face to use for highlighting interpolation delimiters? Date: Fri, 6 Jan 2023 17:36:57 +0200 Message-ID: References: <83a62vvipb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------v8JK79SsigrHWQ0MnfGqvi3y" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28528"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: dev@rjt.dev, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 06 16:38:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDonA-0007CR-DK for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Jan 2023 16:38:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDomP-0002vc-GW; Fri, 06 Jan 2023 10:37:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDomH-0002rs-Io for emacs-devel@gnu.org; Fri, 06 Jan 2023 10:37:05 -0500 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDomF-0004UI-9j; Fri, 06 Jan 2023 10:37:05 -0500 Original-Received: by mail-wm1-x332.google.com with SMTP id g25-20020a7bc4d9000000b003d97c8d4941so3787537wmk.4; Fri, 06 Jan 2023 07:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=sza7X+iCNaOfsJVhov+y9wrJBBAcdQ2gpS9CLZmuS6w=; b=Rz7ShdLGzzKE1XCBgd+b5XTN/lIcMCB6UKq3wZWU3d4HU5g8b8YOw4NtjG/7pUWbVD 9YQV8ZUSdJZ5uM/iyqCBgSeKjYgA89tpqwm14rBp2c+2FD+OzyydaFdVXWhX1rr/fv7a nBFuhqecQgYRdgdHIyaQlQWaaJtAbYEngwIHf949XF2Pd2DEQwiivdYDiwHy9vqu1gaM DcQdCczKxLKCsujmPKp0TcX2MmlkEVcMn1RvojsAjXmAzzT1wViS0+cK9DDBBO95EiOP U24BgbMy9ttcMpH1P0bGzUMXCzCA7F3hMXUxZf41FAP5pauUtzbVU4yofQKecLtrdT8S KJjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sza7X+iCNaOfsJVhov+y9wrJBBAcdQ2gpS9CLZmuS6w=; b=N9yqZP5PJ3N7CPvzbG062GNUsCKn4W75/Us5AcQ7+L6qroyxOSY1xiMkUnSzShgKR0 RJWgLTgYXVEMROh/C/wKgSQL3yk38p+0kn6sb4X++VDp5BtgNKEas8ocmuW+WkUTmR0P 3MltJUM63+THsk88rYdnpKT3rQ4Kb3qjF4eeY0Fky3MpuJyA+MQXrrSATGI8iO1abn1H cO64HqzUYnvt5Ljy1ltajHUZ5Eu4qQzw9cZlk0F9+CctzfWJstBRXA8J9VWpTAOq0RBn H73yjr2kzrVWWXI9KFB75Yat/vXg/7V8oCoJE+KPdBSwtN2IA3tll/0DF0UEsM7kg+lz EpUA== X-Gm-Message-State: AFqh2kououtieVxTP9TOIaIJDbH1eRBnSN9rTXe9tbCayQfzNsgESaoA sL2g3FZUfeaBL98r7LiAkFh9V9zV8cU= X-Google-Smtp-Source: AMrXdXs/tSMVEff72voH3NnTXKE7A8zObKJ6s+efoznVPIi+wSAR6zyTDeHLZ3aqxmE8S3j+1+Y1aA== X-Received: by 2002:a05:600c:2146:b0:3d1:f762:da7f with SMTP id v6-20020a05600c214600b003d1f762da7fmr42666139wml.2.1673019419595; Fri, 06 Jan 2023 07:36:59 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bi22-20020a05600c3d9600b003d208eb17ecsm2043671wmb.26.2023.01.06.07.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 07:36:58 -0800 (PST) Content-Language: en-US In-Reply-To: <83a62vvipb.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=raaahh@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.939, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302254 Archived-At: This is a multi-part message in MIME format. --------------v8JK79SsigrHWQ0MnfGqvi3y Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2023 16:30, Eli Zaretskii wrote: >> Date: Fri, 6 Jan 2023 15:50:02 +0200 >> Cc: emacs-devel >> From: Dmitry Gutov >> >>>> While we're at it, maybe a face for regexp literals as well? >>> Sure. >> Eli, could we still add that in emacs-29? We'll make it simply inherit >> from string and use in a 2-3 ts modes for languages with regexp >> literals. It's a pretty trivial change. >> >> If we defer it until Emacs 30, it will be kinda painful to use in >> ELPA-distributed packages (e.g. python and hopefully ruby as well). > In general OK, but please show the patch to add that, so I could know > exactly what is being proposed. Sure. I think these 3 are the only languages we support that have regexp literals. --------------v8JK79SsigrHWQ0MnfGqvi3y Content-Type: text/x-patch; charset=UTF-8; name="font-lock-regexp-face.diff" Content-Disposition: attachment; filename="font-lock-regexp-face.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggMDU5Mjc4YjA4YTEuLjU5 MDFiMjcxOGU5IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNzk4 LDYgKzc5OCw3IEBAIGZpbHRlci9zZW50aW5lbCBlcnJvciBoYXMgYmVlbiBoYW5kbGVkLgog VGhlc2UgZmFjZXMgYXJlIHByaW1hcmlseSBtZWFudCBmb3IgdXNlIHdpdGggdHJlZS1zaXR0 ZXIuICBUaGV5IGFyZToKICdmb250LWxvY2stYnJhY2tldC1mYWNlJywgJ2ZvbnQtbG9jay1k ZWxpbWl0ZXItZmFjZScsCiAnZm9udC1sb2NrLWVzY2FwZS1mYWNlJywgJ2ZvbnQtbG9jay1u dW1iZXItZmFjZScsCisnZm9udC1sb2NrLXJlZ2V4cC1mYWNlJywKICdmb250LWxvY2stbWlz Yy1wdW5jdHVhdGlvbi1mYWNlJywgJ2ZvbnQtbG9jay1vcGVyYXRvci1mYWNlJywKICdmb250 LWxvY2stcHJvcGVydHktZmFjZScsIGFuZCAnZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2Un LgogCmRpZmYgLS1naXQgYS9saXNwL2ZvbnQtbG9jay5lbCBiL2xpc3AvZm9udC1sb2NrLmVs CmluZGV4IDc0ODgxYTE0Y2NmLi45OWRmOGZiOWUwNiAxMDA2NDQKLS0tIGEvbGlzcC9mb250 LWxvY2suZWwKKysrIGIvbGlzcC9mb250LWxvY2suZWwKQEAgLTIwNzMsNiArMjA3MywxMiBA QCBmb250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UKICAgIkZvbnQgTG9jayBtb2RlIGZhY2Ug dXNlZCB0byBoaWdobGlnaHQgcHJlcHJvY2Vzc29yIGRpcmVjdGl2ZXMuIgogICA6Z3JvdXAg J2ZvbnQtbG9jay1mYWNlcykKIAorKGRlZmZhY2UgZm9udC1sb2NrLXJlZ2V4cC1mYWNlCisg ICcoKHQgOmluaGVyaXQgZm9udC1sb2NrLXN0cmluZy1mYWNlKSkKKyAgIkZvbnQgTG9jayBt b2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgcmVnZXhwIGxpdGVyYWxzLiIKKyAgOmdyb3Vw ICdmb250LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCiAoZGVmZmFjZSBmb250 LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tzbGFzaAogICAnKCh0IDppbmhlcml0IGJvbGQp KQogICAiRm9udCBMb2NrIG1vZGUgZmFjZSBmb3IgYmFja3NsYXNoZXMgaW4gTGlzcCByZWdl eHAgZ3JvdXBpbmcgY29uc3RydWN0cy4iCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9q cy5lbCBiL2xpc3AvcHJvZ21vZGVzL2pzLmVsCmluZGV4IDkwYjkwNjhmZDVkLi5mZTQ4M2Yy MjBkYSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvanMuZWwKKysrIGIvbGlzcC9wcm9n bW9kZXMvanMuZWwKQEAgLTM0OTgsNyArMzQ5OCw3IEBAIGpzLS10cmVlc2l0LWZvbnQtbG9j ay1zZXR0aW5ncwogCiAgICA6bGFuZ3VhZ2UgJ2phdmFzY3JpcHQKICAgIDpmZWF0dXJlICdz dHJpbmcKLSAgICcoKHJlZ2V4IHBhdHRlcm46IChyZWdleF9wYXR0ZXJuKSkgQGZvbnQtbG9j ay1zdHJpbmctZmFjZQorICAgJygocmVnZXggcGF0dGVybjogKHJlZ2V4X3BhdHRlcm4pKSBA Zm9udC1sb2NrLXJlZ2V4cC1mYWNlCiAgICAgIChzdHJpbmcpIEBmb250LWxvY2stc3RyaW5n LWZhY2UpCiAKICAgIDpsYW5ndWFnZSAnamF2YXNjcmlwdApkaWZmIC0tZ2l0IGEvbGlzcC9w cm9nbW9kZXMvcnVieS10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvcnVieS10cy1tb2Rl LmVsCmluZGV4IGJmMDk3MjZiMzRmLi41ZjVkZTUwMDQzNSAxMDA2NDQKLS0tIGEvbGlzcC9w cm9nbW9kZXMvcnVieS10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3J1YnktdHMt bW9kZS5lbApAQCAtMjI3LDEwICsyMjcsOCBAQCBydWJ5LXRzLS1mb250LWxvY2stc2V0dGlu Z3MKICAgIDs7IEFsc28gYmVmb3JlICdvcGVyYXRvciBiZWNhdXNlICUgYW5kIC8gYXJlIG9w ZXJhdG9ycwogICAgOmxhbmd1YWdlIGxhbmd1YWdlCiAgICA6ZmVhdHVyZSAncmVnZXhwCi0g ICA7OyBUT0RPOiBXZSBwcm9iYWJseSBuZWVkIGEgc2VwYXJhdGUgZmFjZSBmb3IgcmVnZXhw cyBldmVyeXdoZXJlLgotICAgOzsgTWF5YmUgYW5vdGhlciBvbmUgZm9yIHJlZ2V4cCBkZWxp bWl0ZXJzIGFzIHdlbGwuCi0gICAnKChyZWdleCAiLyIgQGZvbnQtbG9jay1zdHJpbmctZmFj ZSkKLSAgICAgKHJlZ2V4IF8gKHN0cmluZ19jb250ZW50KSBAZm9udC1sb2NrLXN0cmluZy1m YWNlKSkKKyAgICcoKHJlZ2V4ICIvIiBAZm9udC1sb2NrLXJlZ2V4cC1mYWNlKQorICAgICAo cmVnZXggXyAoc3RyaW5nX2NvbnRlbnQpIEBmb250LWxvY2stcmVnZXhwLWZhY2UpKQogCiAg ICA6bGFuZ3VhZ2UgbGFuZ3VhZ2UKICAgIDpmZWF0dXJlICdvcGVyYXRvcgpkaWZmIC0tZ2l0 IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9k ZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmluZGV4IDQwNDJlMmIxMDEzLi41YTlhN2VlYTk1 OSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCisr KyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbApAQCAtMTUxLDcgKzE1 MSw3IEBAIHR5cGVzY3JpcHQtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICA6bGFu Z3VhZ2UgbGFuZ3VhZ2UKICAgIDpvdmVycmlkZSB0CiAgICA6ZmVhdHVyZSAnc3RyaW5nCi0g ICBgKChyZWdleCBwYXR0ZXJuOiAocmVnZXhfcGF0dGVybikpIEBmb250LWxvY2stc3RyaW5n LWZhY2UKKyAgIGAoKHJlZ2V4IHBhdHRlcm46IChyZWdleF9wYXR0ZXJuKSkgQGZvbnQtbG9j ay1yZWdleHAtZmFjZQogICAgICAoc3RyaW5nKSBAZm9udC1sb2NrLXN0cmluZy1mYWNlCiAg ICAgICh0ZW1wbGF0ZV9zdHJpbmcpIEBqcy0tZm9udGlmeS10ZW1wbGF0ZS1zdHJpbmcKICAg ICAgKHRlbXBsYXRlX3N1YnN0aXR1dGlvbiBbIiR7IiAifSJdIEBmb250LWxvY2stbWlzYy1w dW5jdHVhdGlvbi1mYWNlKSkK --------------v8JK79SsigrHWQ0MnfGqvi3y--