From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: tags Date: Tue, 18 Jun 2019 16:44:17 +0300 Message-ID: References: <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> <83v9x6vpap.fsf@gnu.org> <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149418"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 18 15:44:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdEPX-000ch4-4j for ged-emacs-devel@m.gmane.org; Tue, 18 Jun 2019 15:44:31 +0200 Original-Received: from localhost ([::1]:58170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEPW-0003YG-6v for ged-emacs-devel@m.gmane.org; Tue, 18 Jun 2019 09:44:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53630) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEPQ-0003XR-FZ for emacs-devel@gnu.org; Tue, 18 Jun 2019 09:44:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdEPP-00028Z-Dh for emacs-devel@gnu.org; Tue, 18 Jun 2019 09:44:24 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:41449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdEPP-00026u-49 for emacs-devel@gnu.org; Tue, 18 Jun 2019 09:44:23 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id c2so14048466wrm.8 for ; Tue, 18 Jun 2019 06:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eKY9yN5VaiodU2hgHShGLYMkXNf9esA7WbJlt+xylhI=; b=L2W4acf0buAeGmlpdSzPO3qAQ4emm+0QhzMT7OuESbb3dR+6220pKmKxm3bUw0OTOb NUbRgL9XMIOTw9f1sqBoErPb/MEHkAxGF/QKhEfjZm0rn24/DgQ/+OYTu0gGnn/GBsWx UmYSDtZipzXyoGCzJcH1FedwSfYHhV7/YPzD3hqHNio+K2G/ruFXR/F8GL+TJWVG2beE COrh15FXed88zKqPbPp5UaJc/oaK2GeiGbukUJ50ZfVPdhGHB4Jzr7nRNCX8Gu6MQE6r wUAZp5Wf/Tz9QaN6bfZkKZt4tMJgKK85UeGewrl+mwaUaGicQdfWygfL2t1B/W/9MrwX Xs1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eKY9yN5VaiodU2hgHShGLYMkXNf9esA7WbJlt+xylhI=; b=kMtvFLKirVEKCTji9rkhwp8lnRx14Ww1TINMFDDFTL3G9iDBzUszAwT+SNY4l0V/mw XaEtRzhz0GhSDB109KapFKn9sWBtKkYg965ymnni8R98gG+LOgqUwlPEaRL/R9bw4y3N LhJuLNmgpLgux/tpgFZf6kyT8YfElfjtMw9tE+clujOgKdgaPKcm+uy9/D3Lq+KIZKgx m1SLMc60gmOC3J6Yr5Aq2rUDxDJNpqc08dFsP8xIvX67x1vcDnXxPhl/U+ZW9hVXyd4A AcSrh3M+EgmM1aT9KBCTtGgQ3KK81lhp28gjtyfaJOJ+hsXAV7sL+kUaugFJAEsJpJ00 Pzwg== X-Gm-Message-State: APjAAAWavJPJI1vt+2KXpN32e/NblezrzI74kqgPUFgL3DAzXfosbicO otlUTf6dCoNGpfPlnxbKxdHw5IkE1rE= X-Google-Smtp-Source: APXvYqzebmKK9yoVKabvl0Fpk/nFr4Wuzag/2uMhshYixCaKs5kKYsN87wMRP4IA7zfRdSmmY7Z80A== X-Received: by 2002:adf:f886:: with SMTP id u6mr13836664wrp.23.1560865460917; Tue, 18 Jun 2019 06:44:20 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id q1sm1702431wmq.25.2019.06.18.06.44.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jun 2019 06:44:19 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237841 Archived-At: On 16.06.2019 16:20, Lars Ingebrigtsen wrote: >> esh-mode.el has a peculiar use for find-tag in creating a special >> version of it that "ignores whether the text is read-only". I'm not >> sure why that would matter since the command does not modify the >> buffer contents. > > It's kinda puzzling. The comment in the key binding section is: > > ;; without this, find-tag complains about read-only text being > ;; modified > (if (eq (key-binding [(meta ?.)]) 'find-tag) > (define-key eshell-mode-map [(meta ?.)] 'eshell-find-tag)) > > Perhaps this was somehow necessary in the year 2000 when it was written? Perhaps. No idea. :( >> Should we just remove the command and the custom >> binding? Not sure if eshell-mode just set up xref-find-functions as >> well. Is it supposed to use a tags table, or find-func.el? > > I can't see any mention of xref in the eshell files... Sorry, I meant: Not sure if eshell-mode *should* set up xref-find-functions as well. >> As for viper, I guess the emulation stuff has some UI requrements? >> Otherwise we could use xref-find-definitions and >> xref-find-definitions-other-window there. > > The latter is fine, but the call for find-tag is with the next-p parameter: > > (if (string= tag "") > (find-tag ex-tag t) > (find-tag-other-window ex-tag)) > > How is that done in terms of xref? But what does NEXT-P mean in this context? It's not like there has been a previous invocation of find-tag, was there? BTW, your last change in this function is clearly inadequate: find-tag and xref-find-definitions-other-window present different UIs when there's more locations than one. We shouldn't use both in the same command.