From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
To: Po Lu <luangruo@yahoo.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Andrea Corallo <acorallo@gnu.org>,
acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org
Subject: Re: make check produces 25 failures and hangs (bug #65176).
Date: Sat, 12 Aug 2023 11:30:34 +0200 [thread overview]
Message-ID: <b3b976b8-b94f-f759-e6d2-8a05bae35a68@vodafonemail.de> (raw)
In-Reply-To: <s0d5y5l2k8k.fsf@yahoo.com>
On 2023-08-12 02:10, Po Lu wrote:
>> Repro-case-golfing, hoping that Andrea hasn't started on this yet:
>>
>> (require 'cl-lib)
>> (defun foo ()
>> (interactive)
>> (cl-letf (((symbol-function 'read-string) (lambda (&rest _) "bar")))
>> (message (read-string "Prompt: "))))
>
> Isn't Fread_string a primitive, to which advice has no effect?
Not sure about native compilation and primitives, but on Emacs 29 the
natively compiled function `foo' behaves identically to the non-compiled
one (no prompt). And ERTs rely on that pattern, and have been working
on master until they stopped doing so one or two weeks ago.
next prev parent reply other threads:[~2023-08-12 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 19:18 make check produces 25 failures and hangs (bug #65176) Alan Mackenzie
2023-08-10 19:54 ` chad
2023-08-10 20:14 ` Alan Mackenzie
2023-08-10 20:34 ` Alan Mackenzie
2023-08-10 21:54 ` Jens Schmidt
2023-08-11 5:37 ` Eli Zaretskii
2023-08-11 19:39 ` Jens Schmidt
2023-08-12 0:10 ` Po Lu
2023-08-12 9:30 ` Jens Schmidt [this message]
2023-08-12 18:03 ` Andrea Corallo
2023-08-12 19:09 ` Andrea Corallo
2023-08-13 10:59 ` Jens Schmidt
2023-08-13 11:34 ` Alan Mackenzie
2023-08-13 12:07 ` Eli Zaretskii
2023-08-14 7:51 ` Andrea Corallo
2023-08-14 12:07 ` Eli Zaretskii
2023-08-14 13:38 ` Andrea Corallo
2023-08-14 13:44 ` Eli Zaretskii
2023-08-14 14:13 ` Andrea Corallo
2023-08-14 14:52 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b976b8-b94f-f759-e6d2-8a05bae35a68@vodafonemail.de \
--to=jschmidt4gnu@vodafonemail.de \
--cc=acm@muc.de \
--cc=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=yandros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).