From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Opportunistic garbage collection Date: Wed, 24 Apr 2019 17:17:45 -0700 Organization: UCLA Computer Science Department Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157528"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 25 02:23:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJSB2-000enr-4H for ged-emacs-devel@m.gmane.org; Thu, 25 Apr 2019 02:23:48 +0200 Original-Received: from localhost ([127.0.0.1]:49029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJSB1-0004VB-0h for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 20:23:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJS9t-0004T3-L7 for emacs-devel@gnu.org; Wed, 24 Apr 2019 20:22:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJS5E-00058d-8g for emacs-devel@gnu.org; Wed, 24 Apr 2019 20:17:50 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54816) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJS5D-00058M-Qm for emacs-devel@gnu.org; Wed, 24 Apr 2019 20:17:48 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 44C52161834; Wed, 24 Apr 2019 17:17:46 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SlIRP_g-QooS; Wed, 24 Apr 2019 17:17:45 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 742F816183C; Wed, 24 Apr 2019 17:17:45 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id x7dIQsiea8jR; Wed, 24 Apr 2019 17:17:45 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5BAFB1616C4; Wed, 24 Apr 2019 17:17:45 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235892 Archived-At: That sounds like a good idea. Some minor points: On 4/24/19 1:54 PM, Stefan Monnier wrote: > +needed to triger automatic allocation took place. */) triger -> trigger > + (Lisp_Object factor) Instead of having a factor argument, how about hardwiring in a factor of 2? We can always generalize it later, and maybe we'll never need to generalize it. > + byte_ct new_csgc = consing_since_gc * fact; > + if (new_csgc / fact != consing_since_gc) > + /* Overflow! */ > + garbage_collect (); This assumes byte_ct is not narrower than EMACS_INT, which isn't true on 32-bit platforms --with-wide-int. It also assumes 'fact' is nonzero, which might not be true. (Two more reasons to hardwire 2.) > + consing_since_gc = new_csgc; > + maybe_gc (); > + consing_since_gc /= fact; > I'd feel better if we didn't muck with the global variable and passed the smaller consing value directly to a variant of maybe_gc. > > /* If there is still no input available, ask for GC. */ > if (!detect_input_pending_run_timers (0)) > - maybe_gc (); > + maybe_gc (); /* FIXME: Why? */ > } If we don't know why, let's get rid of it....