unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Cully via "Emacs development discussions." <emacs-devel@gnu.org>
To: Michael Albinus <Michael.Albinus@gmx.de>, miha@kamnitnik.top
Cc: Brian Cully <bjc@kublai.com>, emacs-devel@gnu.org
Subject: Re: master 152c7322c1: * lisp/net/tramp-docker.el: New file.
Date: Mon, 3 Oct 2022 09:44:16 -0400	[thread overview]
Message-ID: <b294e472-a74b-bb5f-afc6-de5e9a5a6b94@spork.org> (raw)
In-Reply-To: <87zgeihyzb.fsf@gmx.de>

On 9/29/22 13:28, Michael Albinus wrote:
> miha@kamnitnik.top writes:
>> It's not unusual to have both podman and docker containers on the same
>> host. But the way tramp-docker.el is arranged currently, it's difficult
>> to have simultaneous tramp connections to both of them. I think it would
>> make sense to have two tramp methods: '/docker:' and '/podman:', and by
>> extension, two defcustoms: tramp-docker-program and
>> tramp-podman-program.
> 
> I agree. Especially, when we have multi-hops to different machines,
> which could offer either docker or podman executables.
> 
> Brian?

Indeed. I hadn't considered this use-case (even though I also have both 
installed, though I only use Tramp with Podman containers for 
development purposes).

As the package is really not much more than the method and variable 
customization options, it may be best to just have duplicates for those 
(eg, both `tramp-docker-program' and `tramp-podman-program'). The 
completion code could be shared, but I'm unsure how higher-level code 
organization would work. My first pass would be to have a single 
`tramp-docker--completion-function' which is used for both the 
`tramp-podman-method' as well as `tramp-docker-method'. My rationale 
being that Podman explicitly copies the Docker command line so that at 
can be used as a drop-in replacement, so the completion function would 
more naturally be associated with Docker than Podman.

-bjc




  reply	other threads:[~2022-10-03 13:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 16:50 master 152c7322c1: * lisp/net/tramp-docker.el: New file miha
2022-09-29 17:28 ` Michael Albinus
2022-10-03 13:44   ` Brian Cully via Emacs development discussions. [this message]
2022-10-03 17:37     ` Michael Albinus
2022-10-04 15:32       ` Brian Cully via Emacs development discussions.
2022-10-04 16:58         ` Michael Albinus
2022-10-04 17:43           ` Brian Cully via Emacs development discussions.
2022-10-04 18:00             ` Michael Albinus
2022-10-04 18:17               ` Brian Cully via Emacs development discussions.
2022-10-04 18:20                 ` Michael Albinus
2022-10-04 18:33                   ` Brian Cully via Emacs development discussions.
2022-10-04 18:36                     ` Michael Albinus
2022-10-04 18:45                       ` Brian Cully via Emacs development discussions.
2022-10-04 19:21                         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b294e472-a74b-bb5f-afc6-de5e9a5a6b94@spork.org \
    --to=emacs-devel@gnu.org \
    --cc=Michael.Albinus@gmx.de \
    --cc=bjc@kublai.com \
    --cc=bjc@spork.org \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).