From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spyros Roum Newsgroups: gmane.emacs.devel Subject: Re: Add completion to compilation-read-command Date: Tue, 24 Dec 2024 13:43:43 +0000 Message-ID: References: <87ttatb9g0.fsf@posteo.net> <87ikr9b5u8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------70ksNq6aLJd7XzzkE0EDsAVv" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: philipk@posteo.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 24 14:44:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQ5Cy-0003Rt-Sm for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Dec 2024 14:44:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ5CX-0002SF-4g; Tue, 24 Dec 2024 08:44:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ5CI-0002LQ-6S for emacs-devel@gnu.org; Tue, 24 Dec 2024 08:43:42 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ5CF-0000CO-It for emacs-devel@gnu.org; Tue, 24 Dec 2024 08:43:41 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AB2CB240101 for ; Tue, 24 Dec 2024 14:43:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735047814; bh=3S+S3/BVmrp+zAHyJVDASBDPhOI5CHSTj9WK62opAQc=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:From: From; b=gV2R/GBxaKAkmWomB3AWB/CZHoYiYzrWn+71Br2dviGhO5JY7COG59tbUgKpLXc7o rTFKND7wwdShumoL/FyvLejYlHtyXGuejWfVJhkGd2C72liURSkmbQp75sqVKajpaP k0Ig+sf19HjyePDxQMwmaXFNXHTvg+FlIyPj5ERk2P7xKFabakxUL0spDt5MnnmtiE S4TCMQTEahkrUzbapnyMbJwK9fvKp1ghoBKJ3bCBnhMRFUDquF5O1lOo1PsW/rlaK1 JpFAZ46tyNJPB7O3KSwxTCkOk0BxDpfyt6VUnNUoLK9SNTfw/19DIXCLNx7+ZE4ax1 9xuvZU/KWv+Lw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHbh51tPdz9rxM; Tue, 24 Dec 2024 14:43:33 +0100 (CET) Content-Language: en-US, el, el-en In-Reply-To: <87ikr9b5u8.fsf@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=spyros.roum@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327011 Archived-At: This is a multi-part message in MIME format. --------------70ksNq6aLJd7XzzkE0EDsAVv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Philip Kaludercic wrote: >>>> , I was >>>> missing auto-complete a lot. >>>> I managed to add this functionality by writing a simple function based >>>> on compilation-read-command that uses completing-read instead of >>>> read-shell-command. >>> Do you know about the `bash-completion' package? It enhances >>> `read-shell-command' completion with completion data provided by bash. >>> It is very easy to set up, >>> >>> (use-package bash-completion :ensure t >>> :init (bash-completion-setup)) >>> >>> should do it. >> I was not aware of this, but it doesn't seem to do what I'm looking for. >> For once, I am not using bash, but even ignoring that it doesn't seem >> to have the effect I'm looking for. >> >> I'm trying to get the compile prompt to suggest completion based on >> past commands I've run. > My bad. In that case, why not use C-r to search `compile-history'? I'm not sure if you are suggesting that I should be able to use C-r in the compile prompt, if so there might be a keybind issue as I'm using evil and C-r does not do that for me. If that's the case, could you name the function that does that? It could be what I'm looking for. >>>> Then I used advice-add to overwrite the >>>> original compilation-read-command with mine. >>>> >>>> So far this works well, and as far as I can tell there is no good >>>> reason not to make compile auto-completing, it already has a history >>>> that you can navigate anyway. >>>> >>>> With that said, this is the first time I write here and the first time >>>> I'm trying to contribute to emacs, so I'm not sure what the best way >>>> to go from here would be. >>>> I think some decisions would need to be taken, for once I am not sure >>>> if it's acceptable to change the default and make it completing or if >>>> there should be an option for it. >>> I am not sure if you meant to attach any code, but that would probably >>> be the best place to start. >>> >>>> Looking forward to your feedback, thanks >> You are right I should have posted code, so here is what I have: >> >>   (defun compilation-read-command-with-autocomplete (command) >>     "Use `completing-read` to add autocomplete powers to compilation read" >>     (completing-read "Compile command: " compile-history >>       nil nil command >>       (if (equal (car compile-history) command) >>         '(compile-history . 1) >>         'compile-history))) >> >>   (advice-add >>     #'compilation-read-command >>     :override #'compilation-read-command-with-autocomplete) > If this were added to Emacs, we probably wouldn't use advice. I think > the best strategy for you would be to prepare a patch against compile.el > and add a user option that allows prompting the user with > completing-read. What do you think? I agree advice is not a good solution if this gets merged, this is just what I have in my config to make it work. I believe an option defaulting to the current behavior is fine, assuming we don't want to just change it to the completing version all together. However, I am somewhat lost on what that option might look like. Probably some customizable option based on which compilation-read-command's internals change to either the current or my version? If so, I will need to figure out how the customizable system works internally in order to use it. Any pointers on that would be appreciated. --------------70ksNq6aLJd7XzzkE0EDsAVv Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Philip Kaludercic wrote: 
                                                                , I was
missing auto-complete a lot.
I managed to add this functionality by writing a simple function based
on compilation-read-command that uses completing-read instead of
read-shell-command.

Do you know about the `bash-completion' package?  It enhances
`read-shell-command' completion with completion data provided by bash.
It is very easy to set up,

   (use-package bash-completion :ensure t
     :init (bash-completion-setup))

should do it.

I was not aware of this, but it doesn't seem to do what I'm looking for.
For once, I am not using bash, but even ignoring that it doesn't seem
to have the effect I'm looking for.

I'm trying to get the compile prompt to suggest completion based on
past commands I've run.

My bad.  In that case, why not use C-r to search `compile-history'?

I'm not sure if you are suggesting that I should be able to use C-r in the compile prompt, if so there might be a keybind issue as I'm using evil and C-r does not do that for me.
If that's the case, could you name the function that does that? It could be what I'm looking for.

Then I used advice-add to overwrite the
original compilation-read-command with mine.

So far this works well, and as far as I can tell there is no good
reason not to make compile auto-completing, it already has a history
that you can navigate anyway.

With that said, this is the first time I write here and the first time
I'm trying to contribute to emacs, so I'm not sure what the best way
to go from here would be.
I think some decisions would need to be taken, for once I am not sure
if it's acceptable to change the default and make it completing or if
there should be an option for it.

I am not sure if you meant to attach any code, but that would probably
be the best place to start.


Looking forward to your feedback, thanks

You are right I should have posted code, so here is what I have:

  (defun compilation-read-command-with-autocomplete (command)
    "Use `completing-read` to add autocomplete powers to compilation read"
    (completing-read "Compile command: " compile-history
      nil nil command
      (if (equal (car compile-history) command)
        '(compile-history . 1)
        'compile-history)))

  (advice-add
    #'compilation-read-command
    :override #'compilation-read-command-with-autocomplete)

If this were added to Emacs, we probably wouldn't use advice.  I think
the best strategy for you would be to prepare a patch against compile.el
and add a user option that allows prompting the user with
completing-read.  What do you think?

I agree advice is not a good solution if this gets merged, this is just what I have in my config to make it work.

I believe an option defaulting to the current behavior is fine, assuming we don't want to just change it to the completing version all together.
However, I am somewhat lost on what that option might look like. Probably some customizable option based on which compilation-read-command's internals change to either the current or my version?

If so, I will need to figure out how the customizable system works internally in order to use it. Any pointers on that would be appreciated.

--------------70ksNq6aLJd7XzzkE0EDsAVv--