From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Davis Herring Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] ash, lsh: Avoid code duplication Date: Tue, 22 Nov 2016 09:48:20 -0700 Organization: XCP-1 Message-ID: References: <87inrg99in.fsf@gmail.com> <83k2bw9673.fsf@gnu.org> <87d1ho953w.fsf@gmail.com> <83bmx892lx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1479833490 18639 195.159.176.226 (22 Nov 2016 16:51:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2016 16:51:30 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 22 17:51:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9EHv-0003Lm-La for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2016 17:51:19 +0100 Original-Received: from localhost ([::1]:56659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9EHz-00084Z-1g for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2016 11:51:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9EFC-0006h6-6A for emacs-devel@gnu.org; Tue, 22 Nov 2016 11:48:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9EF7-0003tL-7d for emacs-devel@gnu.org; Tue, 22 Nov 2016 11:48:30 -0500 Original-Received: from proofpoint4.lanl.gov ([2001:400:4210:400::a4]:42741) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9EF6-0003sY-TR; Tue, 22 Nov 2016 11:48:25 -0500 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by mailgate4.lanl.gov (8.15.0.59/8.15.0.59) with ESMTP id uAMGmL3I023025; Tue, 22 Nov 2016 09:48:21 -0700 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mailrelay1.lanl.gov (Postfix) with ESMTP id 22E2E1432A81; Tue, 22 Nov 2016 09:48:21 -0700 (MST) X-NIE-2-Virus-Scanner: amavisd-new at mailrelay1.lanl.gov Original-Received: from bismuth.lanl.gov (bismuth.lanl.gov [128.165.246.103]) by mailrelay1.lanl.gov (Postfix) with ESMTP id F32C01432A85; Tue, 22 Nov 2016 09:48:20 -0700 (MST) In-Reply-To: <83bmx892lx.fsf@gnu.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.154, 1.0.8, 0.0.0000 definitions=2016-11-22_09:2016-11-22, 2016-11-22, 1970-01-01 signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 2001:400:4210:400::a4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209548 Archived-At: >> --- a/src/lisp.h >> +++ b/src/lisp.h >> @@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int, Lisp_Object); >> /* Defined in data.c. */ >> extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object); >> extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object); >> +Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool); > > No need to declare it here, as it is a static function used only in > the file in which it is defined. In case it helps explain the issue, note that the "extern" here did nothing substantive: functions are extern if not static, and the extern keyword isn't needed to prevent a function declaration being a definition. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.