From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John ff Newsgroups: gmane.emacs.devel Subject: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames' Date: Thu, 19 Dec 2024 18:02:19 +0000 Message-ID: References: <173459970775.288909.12887171645975658795@vcs3.savannah.gnu.org> <20241219091511.B84DEC022CC@vcs3.savannah.gnu.org> <87ikrflx8s.fsf@gmx.de> <868qsblu13.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----0A7QLQUH7Y9PUDPI41DQM7VWM39Q6C" Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Android Cc: gerd.moellmann@gmail.com,Michael Albinus , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 19 19:04:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOKtC-0002iY-5z for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Dec 2024 19:04:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOKsX-000888-Lf; Thu, 19 Dec 2024 13:04:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOKsQ-00084z-AD for emacs-devel@gnu.org; Thu, 19 Dec 2024 13:04:02 -0500 Original-Received: from codemist.co.uk ([217.155.197.248]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOKsN-0005qe-BA; Thu, 19 Dec 2024 13:03:58 -0500 Original-Received: from [172.16.4.31] by codemist.co.uk with esmtp (Exim 4.97.1) (envelope-from ) id 1tOKrf-000000007qM-23I4; Thu, 19 Dec 2024 18:03:11 +0000 In-Reply-To: <868qsblu13.fsf@gnu.org> X-Referenced-Uid: 406993 Thread-Topic: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames' X-Is-Generated-Message-Id: true X-ACL-Warn: No reverse lookup Received-SPF: pass client-ip=217.155.197.248; envelope-from=jpff@codemist.co.uk; helo=codemist.co.uk X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326758 Archived-At: ------0A7QLQUH7Y9PUDPI41DQM7VWM39Q6C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 -------- Original Message -------- From: Eli Zaretskii = Sent: Thu Dec 19 12:46:48 GMT 2024 To: "Gerd M=C3=B6llmann" Cc: michael=2Ealbinus@gmx=2Ede, emacs-devel@gnu=2Eorg Subje= ct: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames' > From= : Gerd M=C3=B6llmann > Cc: emacs-devel@gnu=2Eorg > Date: Thu, 19 Dec 2024 12:59:44 +0100 >=20 > Michael Albinus writes: >=20 > > Gerd Moellmann writes: > > > > Hi Gerd, > > > >> Merge branch 'scratch/tty-child-frames' > >> > >> Add support for child frames on tty > > > > This breaks xt-mouse-tests: > > > > --8<---------------cut here---------------start------------->8--- > > # make -C test xt-mouse-tests > > Test xt-mouse-tracking-basic condition: > > (error "tty frame should be used") > > FAILED 1/3 xt-mouse-tracking-basic (0=2E776520 sec) at lisp/xt-mo= use-tests=2Eel:61 > > Test xt-mouse-tracking-sgr condition: > > (error "tty frame should be used") > > FAILED 2/3 xt-mouse-tracking-sgr (0=2E000466 sec) at lisp/xt-mous= e-tests=2Eel:102 > > Test xt-mouse-tracking-utf-8 condition: > > (error "tty frame should be used") > > FAILED 3/3 xt-mouse-tracking-utf-8 (0=2E000746 sec) at lisp/xt-mo= use-tests=2Eel:80 > > --8<---------------cut here---------------end--------------->8--- > > > > Best regards, Michael=2E >=20 > Hi Michael, >=20 > The new code now _requires_ a tty frame to be used (decode_tty_frame, > check_tty), which I think the tests can't provide, running in batch=2E A= nd > I'd rather not be less picky for the sake of these tests=2E Why is that a problem? A batch session does have a frame, you just need to account for that=2E I think the test that emits the error is too strict, and should be relaxed when noninteractive is non-zero=2E Or maybe invert the test and check for !FRAME_WINDOW_P (which would then allow the frame that exists in the batch session)=2E ------0A7QLQUH7Y9PUDPI41DQM7VWM39Q6C Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
From: Eli Zaretskii
Sent: Thu Dec 19 12:46= :48 GMT 2024
To: "Gerd M=C3=B6llmann"
Cc: michael=2Ealbinus@gmx=2Ede, emacs-devel@gnu=2Eorg
<= b>Subject: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-fram= es'

 From: Gerd M=
=C3=B6llmann <gerd=2Emoellmann@gmail=2Ecom>
 Cc: emacs-devel@gnu=
=2Eorg
 Date: Thu, 19 Dec 2024 12:59:44 +0100
 
 Michael Albinus &=
lt;michael=2Ealbinus@gmx=2Ede> writes:
 
 Gerd Moellmann <gerd@gnu=2Eorg> writes:
<=
br> Hi Gerd,

     M=
erge branch 'scratch/tty-child-frames'

     Add support for child fr=
ames on tty

 This breaks xt-mouse-tests:

 --8<=
;---------------cut here---------------start------------->8---
 # mak=
e -C test xt-mouse-tests
 Test xt-mouse-tracking-basic condition:
   =
  (error "tty frame should be used")
    FAILED  1/3  xt-mouse-tracking-=
basic (0=2E776520 sec) at lisp/xt-mouse-tests=2Eel:61
 Test xt-mouse-tra=
cking-sgr condition:
     (error "tty frame should be used")
    FAIL=
ED  2/3  xt-mouse-tracking-sgr (0=2E000466 sec) at lisp/xt-mouse-tests=2Eel=
:102
 Test xt-mouse-tracking-utf-8 condition:
     (error "tty frame =
should be used")
    FAILED  3/3  xt-mouse-tracking-utf-8 (0=2E000746 se=
c) at lisp/xt-mouse-tests=2Eel:80
 --8<---------------cut here-------=
--------end--------------->8---

 Best regards, Michael=2E
 
 Hi Michael,
 
 The new code now _requires_ a tty frame=
 to be used (decode_tty_frame,
 check_tty), which I think the tests can'=
t provide, running in batch=2E And
 I'd rather not be less picky for the=
 sake of these tests=2E

Why is that a problem?  A batch=
 session does have a frame, you just
need to account for that=2E  I thin=
k the test that emits the error is
too strict, and should be relaxed whe=
n noninteractive is non-zero=2E  Or
maybe invert the test and check for =
!FRAME_WINDOW_P (which would then
allow the frame that exists in the bat=
ch session)=2E


------0A7QLQUH7Y9PUDPI41DQM7VWM39Q6C--