From: John ff <jpff@codemist.co.uk>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gerd.moellmann@gmail.com,Michael Albinus <michael.albinus@gmx.de>,
emacs-devel@gnu.org
Subject: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'
Date: Thu, 19 Dec 2024 18:02:19 +0000 [thread overview]
Message-ID: <b01a8433-59d6-4572-8188-7602e8239593@codemist.co.uk> (raw)
In-Reply-To: <868qsblu13.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]
-------- Original Message --------
From: Eli Zaretskii <eliz@gnu.org>
Sent: Thu Dec 19 12:46:48 GMT 2024
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 19 Dec 2024 12:59:44 +0100
>
> Michael Albinus <michael.albinus@gmx.de> writes:
>
> > Gerd Moellmann <gerd@gnu.org> writes:
> >
> > Hi Gerd,
> >
> >> Merge branch 'scratch/tty-child-frames'
> >>
> >> Add support for child frames on tty
> >
> > This breaks xt-mouse-tests:
> >
> > --8<---------------cut here---------------start------------->8---
> > # make -C test xt-mouse-tests
> > Test xt-mouse-tracking-basic condition:
> > (error "tty frame should be used")
> > FAILED 1/3 xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mouse-tests.el:61
> > Test xt-mouse-tracking-sgr condition:
> > (error "tty frame should be used")
> > FAILED 2/3 xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-tests.el:102
> > Test xt-mouse-tracking-utf-8 condition:
> > (error "tty frame should be used")
> > FAILED 3/3 xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mouse-tests.el:80
> > --8<---------------cut here---------------end--------------->8---
> >
> > Best regards, Michael.
>
> Hi Michael,
>
> The new code now _requires_ a tty frame to be used (decode_tty_frame,
> check_tty), which I think the tests can't provide, running in batch. And
> I'd rather not be less picky for the sake of these tests.
Why is that a problem? A batch session does have a frame, you just
need to account for that. I think the test that emits the error is
too strict, and should be relaxed when noninteractive is non-zero. Or
maybe invert the test and check for !FRAME_WINDOW_P (which would then
allow the frame that exists in the batch session).
[-- Attachment #2: Type: text/html, Size: 2734 bytes --]
prev parent reply other threads:[~2024-12-19 18:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <173459970775.288909.12887171645975658795@vcs3.savannah.gnu.org>
[not found] ` <20241219091511.B84DEC022CC@vcs3.savannah.gnu.org>
2024-12-19 11:00 ` master 8aef5d224a6: Merge branch 'scratch/tty-child-frames' Stefan Kangas
2024-12-19 11:25 ` Gerd Möllmann
2024-12-19 12:44 ` Gerd Möllmann
2024-12-19 14:50 ` Robert Pluim
2024-12-19 14:58 ` Gerd Möllmann
2024-12-19 15:30 ` Robert Pluim
2024-12-19 15:31 ` Gerd Möllmann
2024-12-19 15:09 ` Eli Zaretskii
2024-12-19 11:37 ` Michael Albinus
2024-12-19 11:59 ` Gerd Möllmann
2024-12-19 12:46 ` Eli Zaretskii
2024-12-19 13:19 ` Gerd Möllmann
2024-12-19 13:28 ` Eli Zaretskii
2024-12-19 18:02 ` John ff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b01a8433-59d6-4572-8188-7602e8239593@codemist.co.uk \
--to=jpff@codemist.co.uk \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).