From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: master f9f4f054bc1 1/2: Compare fixnums and floats accurately in value< Date: Thu, 04 Jul 2024 15:16:51 +0000 Message-ID: References: <172010183615.2930.8557271862854647404@vcs2.savannah.gnu.org> <20240704140356.A5E1AC1FB68@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34200"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 04 17:58:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPOr5-0008gX-Js for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jul 2024 17:58:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPOoz-0001eb-Vs; Thu, 04 Jul 2024 11:56:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPOCh-00025Z-LI for emacs-devel@gnu.org; Thu, 04 Jul 2024 11:16:59 -0400 Original-Received: from mail-40133.protonmail.ch ([185.70.40.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPOCf-0004QJ-Ll for emacs-devel@gnu.org; Thu, 04 Jul 2024 11:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720106215; x=1720365415; bh=sINEuUjvRdeTWQdF5+s7uK0HszigWQvd2wwWxmMm+KM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=YyCnawPKQRi4ZinvQkfpS62cwOMrU2mBKypzz57oKw1p03NI0KVvDXAamfVAmMVCR xVDAWsMju39WOGGi+pMklp8GoCiGTuWMQGrTLO85bQ31stT5qDQLiNaBFCUv8+ZRC0 Kmq2gHqT6dOBhYTc5Q1ugrQvXzV2zBCmEjaB6CIEjnFZGQxphF66TyPnDWNItrXl4m hAeNoLGoj52qlvijeUFjDhYvQOxK/Xr1UCPwb0sdVJmQH87gjk3Jev1awCl9YDvZfC GwaLs2JmvcweWCfhlaz6+4iYDBRrszGsk3Kvq3jQgR2Uqj7Z5wYiYpVuwl/mO7L2uA QrE9Ni5Rv8jHw== In-Reply-To: <20240704140356.A5E1AC1FB68@vcs2.savannah.gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: f82f27563eccf3b3e6ed1e07202af0e380be0282 Received-SPF: pass client-ip=185.70.40.133; envelope-from=pipcet@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 04 Jul 2024 11:56:25 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321332 Archived-At: Hello Mattias, On Thursday, July 4th, 2024 at 14:03, Mattias Engdeg=C3=A5rd via Mailing li= st for Emacs changes wrote: > Compare fixnums and floats accurately in value< > > Make `value<` compare fixnums and floats by value, as `<` does, instead > of coercing the fixnum to a float first which is what C would do. > This matters when the fixnum cannot be represented as a float. For > example, C would evaluate > > 72057594037927935 < 72057594037927936.0 > > to false since the operands are converted to the same floating-point > number. Can you add a comment to fixnum_float_cmp explaining that it only works for= fixnums (62 / 30 bits), not for arbitrary EMACS_INTs (64 / 32 bits)? Or is= that totally obvious? Pip