From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 07 Dec 2020 22:56:27 +0000 Message-ID: References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> <874kkx6zwj.fsf@gnus.org> <87zh2p5ksl.fsf@gnus.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="-212064758-622010909-1607381786=:23058" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4633"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 23:57:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmPRT-00015p-Ob for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 23:57:15 +0100 Original-Received: from localhost ([::1]:41240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmPRS-0004nP-R2 for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 17:57:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmPQq-0004Ml-Vt for emacs-devel@gnu.org; Mon, 07 Dec 2020 17:56:36 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:63981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmPQo-0000Sg-Op; Mon, 07 Dec 2020 17:56:36 -0500 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 0B7MuTEL027030 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 7 Dec 2020 22:56:30 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 0B7Mv6HF017457; Mon, 7 Dec 2020 22:57:06 GMT In-Reply-To: <87zh2p5ksl.fsf@gnus.org> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260532 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---212064758-622010909-1607381786=:23058 Content-Type: text/plain; charset=ISO-8859-7; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE > With this change, the toolbar should no longer bust the image cache. > > Gregory, can you benchmark with this change (on an otherwise unchanged=20 > trunk, i.e., with equal_lists, not !equal_lists)? > > diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el > index 8456216430..c3d0841d0c 100644 > --- a/lisp/tool-bar.el > +++ b/lisp/tool-bar.el > @@ -154,12 +154,12 @@ tool-bar--image-expression > (concat icon ".pbm")) colors)) > =09 (xbm-spec (append (list :type 'xbm :file > (concat icon ".xbm")) colors))) > - `(find-image (cond ((not (display-color-p)) > -=09=09=09',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec)) > -=09=09 ((< (display-color-cells) 256) > -=09=09=09',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec)) > -=09=09 (t > -=09=09=09',(list xpm-spec pbm-spec xbm-spec)))))) > + `(cond ((not (display-color-p)) > +=09 ',(find-image (list pbm-spec xbm-spec xpm-lo-spec xpm-spec))) > +=09 ((< (display-color-cells) 256) > +=09 ',(find-image (list xpm-lo-spec xpm-spec pbm-spec xbm-spec))) > +=09 (t > +=09 ',(find-image (list xpm-spec pbm-spec xbm-spec)))))) > > ;;;###autoload > (defun tool-bar-local-item (icon def key map &rest props) > Hmmm... this fails with: Loading /home/ghe/local/src/emacs/lisp/indent.el (source)... Loading /home/ghe/local/src/emacs/lisp/emacs-lisp/cl-generic.el (source)... Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Eager macro-expansion failure: (void-variable image-load-path) Symbol=A2s value as variable is void: image-load-path ---212064758-622010909-1607381786=:23058--