From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Fri, 06 Nov 2020 08:42:56 +0000 Message-ID: References: <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> <20201105210915.3rl3z6jngsrzgbwv@Ergus> <20201105223615.xg43vj3o733x5uqc@Ergus> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 09:44:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaxLv-00079h-BV for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 09:44:11 +0100 Original-Received: from localhost ([::1]:52162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaxLu-0003HW-9X for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 03:44:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaxKt-0002Mq-Gb for emacs-devel@gnu.org; Fri, 06 Nov 2020 03:43:07 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:51481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaxKr-0003MR-Vz for emacs-devel@gnu.org; Fri, 06 Nov 2020 03:43:07 -0500 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 0A68gwjx020876 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 6 Nov 2020 08:42:58 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 0A68hQUt016537; Fri, 6 Nov 2020 08:43:26 GMT In-Reply-To: <20201105223615.xg43vj3o733x5uqc@Ergus> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 03:42:24 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258784 Archived-At: >> My point is that now that `(setq icomplete-separator "\n")' works (in >> most but not all cases), there is no need for the specific >> vertical-icomplete implementation anymore. What is (or could be) >> needed is an implementation that is "more correct" (correct in all >> cases). > > I don't totally agree is the same than the branch. > > The completion like "compi{compilation" with fido mode is still there, > in the same line and is not intuitive; the ellipsis is not shown and the > {} and [] are still there and hard coded. icomplete-prospects-height is > not respected either because the number of candidates is still > calculated with the window-width and adding the candidates length which > actually makes no sense at all in vertical mode. > These are details, which AFAICS require only minor modifications to the existing code.