From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Mon, 05 Oct 2020 13:19:53 +0000 Message-ID: References: <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <83blhhdy3w.fsf@gnu.org> <87d01xghmt.fsf@gmail.com> <83sgatc8er.fsf@gnu.org> <83mu11c78j.fsf@gnu.org> <87tuv9eygk.fsf@gmail.com> <87imbogb6k.fsf@gmail.com> <83eemcdgg2.fsf@gnu.org> <83d01wdf8p.fsf@gnu.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35538"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: spacibba@aol.com, emacs-devel@gnu.org, casouri@gmail.com, joaotavora@gmail.com, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 05 15:23:57 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPQT7-00099w-8z for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 15:23:57 +0200 Original-Received: from localhost ([::1]:33164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPQT6-0002se-Bf for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 09:23:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPQPS-0000Hh-HU for emacs-devel@gnu.org; Mon, 05 Oct 2020 09:20:10 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:51719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPQPP-0003rT-2M; Mon, 05 Oct 2020 09:20:10 -0400 Original-Received: from sdf.org (IDENT:ghe@otaku.sdf.org [205.166.94.8]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 095DJv8X015011 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 5 Oct 2020 13:19:57 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 095DJuL1023937; Mon, 5 Oct 2020 13:19:56 GMT In-Reply-To: <83d01wdf8p.fsf@gnu.org> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/05 06:53:34 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257126 Archived-At: >> The solution in this thread works at the Lisp level, and will not >> affect other uses of the miniwindow, because it relies on a >> minibuffer-local variable. AFAICS it is also safe wrt recursive >> editing. > > Using a buffer-local variable doesn't necessarily eliminate the problems > with recursive-edit. And using window-scroll-functions for this purpose > is a no-no. So I cannot endorse this others solution, either. > Once again I have to stop a discussion with you, because I do not want to start a public dispute with you. You reject everything I propose with vague statements about "potential problems", without any detail or recipe that would help me or others to see whether these "potential problems" are real or minor ones. Note that what you object to (using set-window-start in window-scroll-functions) is, in fact, already used twice in Emacs core. In em-smart.el, eshell-smart-initialize adds eshell-smart-scroll-window to window-scroll-functions, eshell-smart-scroll-window calls eshell-smart-redisplay, and eshell-smart-redisplay uses set-window-start. Likewise, follow.el adds follow-avoid-tail-recenter to window-scroll-functions, and follow-avoid-tail-recenter uses set-window-start. In both cases, the code was already present in Emacs 21. Which means that it has been used for twenty years without known problems.